Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Support Oreo autofill #7355

Open
LaurenWags opened this issue May 1, 2018 · 51 comments
Open

[Android] Support Oreo autofill #7355

LaurenWags opened this issue May 1, 2018 · 51 comments
Assignees
Labels
feature/autofill feature-request OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon".

Comments

@LaurenWags
Copy link
Member

Requested via community and GitHub:
Users would like Brave to support Oreo autofill.
https://community.brave.com/t/support-for-andriod-oreo-autofill/14641
https://github.com/brave/browser-android-tabs/issues/560

@tobia
Copy link

tobia commented Aug 12, 2018

This is needed for 1password integration in Android.

Please test it with 1password for Android, to make sure Brave is providing the right context.

@puechtom
Copy link

This feature is lacking. Since I'm using 1password, I can't use Brave on Android

@tobia
Copy link

tobia commented Aug 24, 2018

@ClarkTom Don't be so drastic. Your can use the 1Password special keyboard, or good old copy and paste. If you have many fields to fill in, you can put 1Password in split screen so that it doesn't lock up after you copy every field.

But yes, autofill would be useful.

vvv Edit: why the downvotes? Anyways, it's working now.

@MKahmen
Copy link

MKahmen commented Sep 12, 2018

Seems to be fixed / working in the latest android version! 👍

@puechtom
Copy link

Yes, I have also noticed it ! That's a good news 👍

@johnbillion
Copy link

With the latest Brave and the recently released 1Password 7 on Android, this appears to be working a treat!

@screendriver
Copy link

For me unfortunately not. I'm using Enpass and it works in Firefox Focus and the DuckDuckGo Browser but not in Brave 😢

@nooz
Copy link

nooz commented Sep 12, 2018

Autofill with Keepass2Android still not working as of v1.0.57

@rob151515
Copy link

There seems to be an issue with the implementation of autofill.

I've been doing some testing with the Brave browser on a Pixel 2 using Android Pie and autofill seems to work the first time the browser is opened from a cold start (ie. swipe it away from recents, then open it again) - you get the autofill prompt on the page.

If I then hit the home button to minimise the browser, then go and open it straight back up, the autofill prompt no longer shows. I have to then kill the browser by swiping it away in recents then open it again to get it to work.

I have also tested DuckDuckGo & Chrome browsers on the same device and they are working fine so the problem seems to be limited to this browser.

@Michi0301
Copy link

I use Engpass to store passwords.
I can confirm that the auto fill option shows up in the Duckduckgo browser but not in Brave, so I would assume there is something missing in Brave.

@beevvy
Copy link

beevvy commented Nov 9, 2018

I can confirm that autofill doesn't work in Brave 1.0.61 with LastPass on a Pixel 2. It works just fine in Chrome 70.

@leobel96
Copy link

It works in brave 1.0.61 with bitwarden as password manager and android 9.0

@Brave-Matt
Copy link

@PlanetWilson
Copy link

PlanetWilson commented Dec 31, 2018

Autofill not working for me either on 1.0.72 and enpass on Android. Pity as it makes it pretty unusable for me. Works fine on Chrome.

@PlanetWilson
Copy link

PlanetWilson commented Jan 1, 2019

So after more testing with Enpass I can get the system autofill notification to appear but not the one that should appear dropped down from the username field itself. If I do happen to go with the system autofill notification then Enpass asks what credentials I wish to pass to "Brave" rather than the URL I am visiting. i.e. it is like Brave is not passing the URL to the autofill service itself. (similar issue mentioned here https://discussion.enpass.io/index.php?/topic/5563-wrong-autofill-information-gets-added-automatically/&tab=comments#comment-11998 with a different browser)

Update: So I think I have been getting confused with the old accessibility way of doing Autofill (system notification) and the new Android Pie autofill where it should appear in browser. I was seeing the Accessibility mechanism, I have since turned this off. No matter what pass word manager I use (tried enpass and 1Password) I cannot get the in browser/Android Pie autofill to fire at all with Brave.

@RichyHBM
Copy link

RichyHBM commented Jan 5, 2019

This seems to be an issue with chromium, I have tried a number of chromium based browsers (kiwi, bromite, chromium) and autofill doesn't work in any of these.

In fact chrome doesn't work with lastpass, m.facebook.com doesn't offer me autofill to log in where as when using firefox focus it does show up

@PlanetWilson
Copy link

PlanetWilson commented Jan 15, 2019

Enpass and 1Password work with Chrome and Firefox Focus, Duck Duck Go browser and Dolphin for me but not with Brave.

@armstrys
Copy link

Autofill still not working for me on Brave 1.0.77 and android 8.0.

Hope a fix is around the corner as it's my only (small) gripe with Brave! Thanks!

@Rouzax
Copy link

Rouzax commented Apr 8, 2019

Also not working for me on:
Brave 1.0.89
Android 9.0 Galaxy A8
1Password 7.1.3

@sjdrc
Copy link

sjdrc commented Apr 16, 2019

Same issue on:
Pixel 2 XL PQ2A.190405.003
Brave 1.0.89
Bitwarden 1.22.0

@sjdrc
Copy link

sjdrc commented Apr 26, 2019

Interestingly, I am able to use BitWarden autofill from Brave webview tabs (at least in some circumstances). When I try to log into a slack account with google SSO enabled through the slack app, it opens a brave custom tab (has the brave logo in top right) and offers me the regular system autofill popup. Same thing does not get offered when trying to log into gmail through the Brave app.

@Rouzax
Copy link

Rouzax commented May 7, 2019

Still autofill saving is not working:
Brave 1.0.92
Android 9.0 Galaxy A8
1Password 7.1.4

If there is any need for logfiles let me know.

@bdcarr
Copy link

bdcarr commented May 18, 2019

I don't see the autofill menu appear at all in Brave.

Brave 1.0.92
Keepass2Android 1.07-r1
Android 9.0
Galaxy A50 (SM-A505F/DS)

@sys9kdr
Copy link

sys9kdr commented May 19, 2019

I have same issue. Pop-up doesn't show.

  • Brave 1.0.94
  • Lastpass
  • Android 9.0
  • Huawei P10

@Rouzax
Copy link

Rouzax commented Jun 21, 2019

Is there any update/confirmation on this?

@ragregory42
Copy link

I have same issue. Autofill non-functional.
Brave 1.0.99
Bitwarden Autofill Framework/Bitwarden v2.0.6
Android 8.0.0
LG V30

@josephsteele
Copy link

Same issue for me:
Brave v1.0.99
Bitwarden v2.0.6
Android 9
Samsung S8

@dunxd
Copy link

dunxd commented Jul 19, 2019

I'm finding the autofill works very intermittently with the following:
Brave v1.1.1
Bitwarden 2.1.0
Android 9
Motorola One

I frequently have to open Bitwarden, search, copy password and paste into Brave. Occaisionaly I get the pop-up under a login field - but more often than not I don't get it.

@hoejmann
Copy link

Have never been able to get the autofill option to appear.
Google Pixel 2
1 Password 7.3
Brave 1.2
Android 9

@tjm00
Copy link

tjm00 commented Jan 22, 2020

This would be a significant improvement.

@DragoCubed
Copy link

samsung internet recently added support for it but has a whitelist. it's proprietary though.

@srirambv srirambv changed the title Support Oreo autofill [Android] Support Oreo autofill Sep 9, 2020
@anthonypkeane anthonypkeane added the priority/P4 Planned work. We expect to get to it "soon". label Sep 9, 2020
@anthonypkeane
Copy link

Can someone please check and verify if this still an issue? Thanks

@Pantamis
Copy link

Still an issue with the Brave version I updated today on Google Play Store. No UI displayed to fill passwords with Oreo autofill.

Could be linked to this maybe: android-password-store/Android-Password-Store#921

If yes then it should be fixed soon in Chromium with this fix https://chromium-review.googlesource.com/c/chromium/src/+/2288852

Hope it helps...

@mraonea
Copy link

mraonea commented Nov 9, 2021

Firefox supports android password autofill

@zhongkechen
Copy link

A 5y bug - it's the only reason I'm not using brave yet

@zhongkechen
Copy link

Bromite supports autofill. Can their patch be ported to Brave?

@hostops
Copy link

hostops commented Nov 22, 2022

@zhongkechen same here. I tried Brave 2 years ago, 1 year ago and now.
And every time I decided that it is not mature yet because of this.

I would just like to use my password manager KeepassDX but I cannot because of this: #26733

@zhongkechen
Copy link

@timchilds Can you prioritize this issue? Maybe P2?

@esdnm
Copy link

esdnm commented Jan 7, 2023

All my passwords are in Google's Password manager, allowing me to have passwords managed across my Android devices without needing to use external software.

Brave not supporting Android's Auto fill making using it a bit difficult, since in order to login I need to copy paste authentication informations.

@Ferk
Copy link

Ferk commented Aug 2, 2023

I'm able to use KeePassDX as a password manager via autofill, it does work after you configure KeePassDX to be the default Autofill service for Android in the Android settings and disable Brave's builtin password manager.

The issue is that very often the domain / URL of the page is not transmitted to the Autofill for its use as keyword, so it instead defaults to the identifier of the app, com.brave.browser.

This happens, particularly, when brave is opened from within another app, or when you open a website installed as a shortcut in the Android launcher.

This last instance is easy to reproduce:

  1. Open Brave app on Android
  2. Access github.com
  3. press the 3 dots menu and select "Add to Home screen"
  4. Accept to add an icon to your launcher to open the Github website
  5. Try to login (press first sign up, then sign in)
  6. Attempt to use the autofill in the login form

@Seedthis
Copy link

Seedthis commented Aug 3, 2023

I don't use 1Password anymore but I know that since the release of v8 for Android, accessibility got removed, maybe it happened before that, I don't know. Bitwarden still has accessibility features but I'd prefer not to use that solution.

When I need autofill on a chromium fork I use Cromite (Bromite successor) with native autofill enabled (default). Works on a completely degoogled phone (no play services, no microg).

I would like to use Brave more on mobile as it is synced with a laptop I use but without autofill it's tedious especially since I don't keep cookies.

I just hope a solution like the one Bromite/Cromite uses gets implemented soon.

@M00NJ
Copy link

M00NJ commented Aug 26, 2023

It's been over five years now, and this issue hasn't even been formerly addressed. I think it's safe to assume that this will never be fixed. How is autofill support only P4? It's a deal breaker...

@lodart
Copy link

lodart commented Sep 7, 2023

It's been over five years now, and this issue hasn't even been formerly addressed. I think it's safe to assume that this will never be fixed. How is autofill support only P4? It's a deal breaker...

Other chromium-based already fixed this. It shouldn't be that hard ! It is also a deal breaker for me

@deeppandya deeppandya assigned tapanmodh and unassigned timchilds Jan 9, 2024
@Repowave
Copy link

Repowave commented Jan 14, 2024

I believe this is a duplicate of #26733 at this point. Only that bug has a few potential solutions suggested (Patches from Vanadium and others).

Edit/Update: For anyone following this, I'd like to report that - at least for me - it has been resolved in the latest Brave update (1.65.114) which patch notes include:

  • Upgraded to Chromium 124.
  • Registered Brave as the autofill service for addresses.
  • Added an option to disable autofill in private browsing mode.

To reiterate, I'm on a custom Android ROM and I've tested with multiple password managers that hadn't worked prior to this update - no Accessibility Mode needed. :)

Note: This does require the brave://flags #enable-autofill-virtual-view-structure to be Enabled and the resulting "Autofill Options" set to "Use other providers" in order to function. Semi-related, you might want to also enable #web-authentication-android-credential-management to use PassKeys if your password manager supports them.

@deeppandya deeppandya assigned deeppandya and unassigned tapanmodh Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/autofill feature-request OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests