Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards settings page on android-core has a number of issues. #8259

Closed
gdregalo opened this issue Feb 14, 2020 · 5 comments · Fixed by brave/brave-core#4696
Closed

Rewards settings page on android-core has a number of issues. #8259

gdregalo opened this issue Feb 14, 2020 · 5 comments · Fixed by brave/brave-core#4696
Assignees
Labels

Comments

@gdregalo
Copy link

gdregalo commented Feb 14, 2020

Description

  1. Claiming a promotion doesn't work (both ugp and ads).
    1.1. Once it works please test scenario with multiple claims
    (similar problem in tabs repo: When have multiple grants, claiming one deletes the next one on the html settings page #7760).
  2. Tips Settings: Enable content-level tips on these sites is not available on Android yet. It has to be removed.
  3. Setting page doesn't have info on monthly tips. There is no way to remove a monthly-tip for a publisher.
  4. AC "Show all" dialog has elements with text sliding out of borders.

Steps to reproduce

Actual result

Expected result

Issue reproduces how often

Issue happens on

  • Current Play Store version?
  • Beta build?

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@gdregalo gdregalo added OS/Android Fixes related to Android browser functionality android-core-release labels Feb 14, 2020
@gdregalo gdregalo added this to the Android 1.5.x Release milestone Feb 14, 2020
@gdregalo
Copy link
Author

Item #4.
Screenshot_20200214-165912

@gdregalo
Copy link
Author

@NejcZdovc plase assign someone with web expertise to help with this.
cc: @SergeyZhukovsky @samartnik

@NejcZdovc
Copy link
Contributor

brave/brave-core#4696 fixed everything except of #1. @gdregalo @ryanml could you please create new issue for it so that we don't loose track of it

@gdregalo
Copy link
Author

@NejcZdovc @ryanml @SergeyZhukovsky
Opened a new issue and gave it a P1 priority: #8367.

@LaurenWags LaurenWags added the ARM Android ARM related issues label Mar 20, 2020
@srirambv
Copy link
Contributor

srirambv commented Mar 26, 2020

Verification passed on OnePlus 6T with Andriod 10 running 1.5.117 x64 stable build

  • Verified able claim UGP and Ads grant both via BR panel and rewards page
  • Verified no setting for content level tipping
    image
  • Verified rewards page has a separate section for monthly contributions(tips)
    image
  • Verified "Show all" dialog elements are not overflowing
    image
    image

Verification passed on OnePlus 6T with Andriod 10 running 1.5.117 x64 stable build

  • Verified able claim UGP and Ads grant both via BR panel and rewards page
  • Verified no setting for content level tipping
    image
  • Verified rewards page has a separate section for monthly contributions(tips)
    image
  • Verified "Show all" dialog elements are not overflowing
    image
    image

Verification passed on Samsung Galaxy J3 version 5.1.1 running BraveModernarm 1.5.117.apk

  • Verified able claim UGP and Ads grant both via BR panel and rewards page
  • Verified no setting for content level tipping
    image
  • Verified rewards page has a separate section for monthly contributions(tips)
    image
  • Verified "Show all" dialog elements are not overlapping
    image

Logged #8875
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants