Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Undefined ImportDataHandler symbols #8356

Closed
emerick opened this issue Feb 21, 2020 · 0 comments · Fixed by brave/brave-core#4711
Closed

[Android] Undefined ImportDataHandler symbols #8356

emerick opened this issue Feb 21, 2020 · 0 comments · Fixed by brave/brave-core#4711
Assignees
@emerick
Labels
dev-concern OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Milestone
1.7.x - Release

Comments

@emerick
Copy link
Contributor

emerick commented Feb 21, 2020

Undefined symbols when building the latest master on Android:

ld.lld: error: undefined symbol: settings::ImportDataHandler::ImportDataHandler()
>>> referenced by brave_settings_import_data_handler.cc:10 (../../brave/browser/ui/webui/settings/brave_settings_import_data_handler.cc:10)
>>>               obj/brave/browser/ui/ui/brave_settings_import_data_handler.o:(settings::BraveImportDataHandler::BraveImportDataHandler())

ld.lld: error: undefined symbol: settings::ImportDataHandler::~ImportDataHandler()
>>> referenced by brave_settings_import_data_handler.cc:11 (../../brave/browser/ui/webui/settings/brave_settings_import_data_handler.cc:11)
>>>               obj/brave/browser/ui/ui/brave_settings_import_data_handler.o:(settings::BraveImportDataHandler::~BraveImportDataHandler())

ld.lld: error: undefined symbol: settings::ImportDataHandler::RegisterMessages()
>>> referenced by brave_settings_import_data_handler.cc
>>>               obj/brave/browser/ui/ui/brave_settings_import_data_handler.o:(vtable for settings::BraveImportDataHandler)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
dev-concern OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Projects
None yet
Milestone
1.7.x - Release
Development

Successfully merging a pull request may close this issue.

Don't build brave_settings_import_data_handler on Android brave/brave-core
2 participants
@bsclifton @emerick