Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question/Feature Request] Service worker is blocked too aggressively #8472

Closed
bigopon opened this issue Feb 29, 2020 · 7 comments
Closed

[Question/Feature Request] Service worker is blocked too aggressively #8472

bigopon opened this issue Feb 29, 2020 · 7 comments

Comments

@bigopon
Copy link

bigopon commented Feb 29, 2020

Description

The main issue thread is here dumberjs/dumber-gist#19. A TLDR version of that would be Brave is blocking [...].example.com even example.com is added to allowed list in cookies settings.

Steps to Reproduce

  1. Add [*.]gist.dumber.app to allowed cookies
  2. Visit https://buttonwoodcx.github.io/doc-bcx-validation/examples/foreach-and-nested
  3. The example demos doesn't work in the iframes

Other Additional Information:

  • Turning off Brave shield doesn't give any effect
  • I don't have Brave rewards on
  • Chrome/Firefox both work fine after the permission config
@3cp
Copy link

3cp commented Mar 2, 2020

I tried to update dumber-gist to at least propagate the inner iframe error to the parent window (which is also in an iframe).

Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('https://860fbf29a89bab9a053aa47be4982a7a.gist.dumber.local') does not match the recipient window's origin ('https://gist.dumber.local').

Does Brave have some implicit sandbox setting on iframe?

@3cp
Copy link

3cp commented Mar 2, 2020

I can reproduce the same issue in Chrome by turning off

Screen Shot 2020-03-03 at 10 06 46 am

The issue is, brave has this one turned on by default (which is what we want), but still got error in iframe.

@rebron
Copy link
Collaborator

rebron commented Apr 17, 2020

@bigopon @3cp Can you go into brave://version and let us know where you're seeing this. With shields down, the example site provided seems to be working. Our latest release version is 1.7.92

e.g.

Brave 1.8.78 Chromium: 81.0.4044.92 (Official Build) beta (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS macOS Version 10.15.5 (Build 19F62f)

@3cp
Copy link

3cp commented Apr 17, 2020

It worked for me with Shied off.

@bigopon
Copy link
Author

bigopon commented Apr 18, 2020

It now works for me, probably you updated it in some recent versions?
Brave:

Brave 1.8.77 Chromium: 81.0.4044.92 (Official Build) dev (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS Windows 10 OS Version 1903 (Build 18362.778)

I have shield on with the following:
image

Now I' now sure which to delete

@3cp
Copy link

3cp commented Apr 18, 2020

@bigopon I guess this can be closed.

@bigopon
Copy link
Author

bigopon commented Apr 18, 2020

@rebron thanks for checking. I guess this can be closed. Is there anything to be aware of in case of a future bug related to this?

@bigopon bigopon closed this as completed Apr 18, 2020
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants