Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top Level Document Blocking #8559

Closed
pes10k opened this issue Mar 6, 2020 · 3 comments
Closed

Top Level Document Blocking #8559

pes10k opened this issue Mar 6, 2020 · 3 comments
Labels
closed/duplicate Issue has already been reported feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality OS/Desktop privacy privacy-pod Feature work for the Privacy & Web Compatibility pod

Comments

@pes10k
Copy link
Contributor

pes10k commented Mar 6, 2020

Problem
uBlock Origin, Brave’s current competitor for the best blocking tool, allows filter list authors to block the top-level, first-party request. This is useful when a page is overall harmful, but doesn’t fit SafeBrowsing’s threat model. It’s also useful as a (not perfect, but effective) defense against phishing, bounce tracking, etc. Similar to browser UI for cert errors, uBlock Origin allows users to “click-through” to access the blocked page.

Brave currently does not have this capability. Brave should implement this capability.

Proposal
Safe-Browsing Style Interstitial

  • Add capability to adblock-rust to know about top level requests (distinct from other request types) and to reason about $document and ~document narrowing cases.
  • Use existing safe-browsing interstitial to create an inert (no storage, no network request, no origin) page that allows “yes I really want to see this page” click through. This could leverage existing chromium infrastructure.
  • Create new interstitial page with Brave branding.
  • Have options for going back, continuing, and "dont ask again"

Designs

This is a full-screen HTML page and should use our web UI.

Desktop:
image

Mobile:
image

Assets

Figma: https://www.figma.com/file/aJu3WGDztEWNZgwQTD9yx2/?node-id=0%3A1

@pes10k pes10k added feature/shields The overall Shields feature in Brave. privacy privacy-pod Feature work for the Privacy & Web Compatibility pod labels Mar 6, 2020
@pes10k pes10k mentioned this issue Mar 6, 2020
3 tasks
@karenkliu
Copy link

Designs and assets added!

@anthonypkeane anthonypkeane added OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 11, 2021
@antonok-edm
Copy link
Collaborator

@pes10k is this a duplicate of #14134? Do the designs need to be updated in the browser to match this?

@pes10k
Copy link
Contributor Author

pes10k commented Mar 17, 2021

Yes, lets close this in favor of #14134 .

@pes10k pes10k closed this as completed Mar 17, 2021
@pes10k pes10k added the closed/duplicate Issue has already been reported label Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported feature/shields The overall Shields feature in Brave. OS/Android Fixes related to Android browser functionality OS/Desktop privacy privacy-pod Feature work for the Privacy & Web Compatibility pod
Projects
None yet
Development

No branches or pull requests

4 participants