Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS dock icon should be smaller #8662

Closed
cperezabo opened this issue Mar 12, 2020 · 14 comments · Fixed by brave/brave-core#7086
Closed

macOS dock icon should be smaller #8662

cperezabo opened this issue Mar 12, 2020 · 14 comments · Fixed by brave/brave-core#7086
Assignees
Labels
design A design change, especially one which needs input from the design team misc/icons OS/Desktop OS/macOS priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/include

Comments

@cperezabo
Copy link

Could you make the app icon smaller? It doesn't look good among the rest of the icons! It's even taller than the Jetbrain icons!
Captura de Pantalla 2020-03-12 a la(s) 15 40 38

@cperezabo cperezabo changed the title macOS icon size should be smaller macOS icon should be smaller Mar 12, 2020
@bsclifton
Copy link
Member

@bsclifton bsclifton added design A design change, especially one which needs input from the design team misc/icons labels Mar 12, 2020
@karenkliu
Copy link

lol it really is huge! 😂

@cperezabo
Copy link
Author

Yeah! if you compare with the Apple icons it's a big boy!

Captura de Pantalla 2020-03-12 a la(s) 17 02 52

@karenkliu
Copy link

The design team is on it! 💪 Probably just needs a simple resize...

@karenkliu karenkliu self-assigned this Mar 12, 2020
@cperezabo
Copy link
Author

You are the best!

@rebron rebron changed the title macOS icon should be smaller macOS dock icon should be smaller Mar 12, 2020
@bsclifton
Copy link
Member

@cezaraugusto did you get a chance to check this out?

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Apr 20, 2020
@cezaraugusto cezaraugusto removed their assignment May 18, 2020
@rebron rebron self-assigned this Jun 22, 2020
@cperezabo
Copy link
Author

Any news about this? It's so disruptive to the dock! 🤯

@bradleyrichter
Copy link

This issue fell through the cracks but we can pick it up.

It looks like 90% is the right scale factor.

current:
image

reduced to 90%:

image

While this brings its actual area down to below average, the visual weight - considering the color - is probably about right.

@cperezabo
Copy link
Author

I think that size is ok. The base problem with the icon is that it should have gained some width because the aspect ratio does not favor it. But I am not a designer, just a developer who loves UI/UX so I could be completely wrong.

@rebron rebron assigned simonhong and unassigned rebron Sep 29, 2020
@karenkliu
Copy link

@simonhong Do you still need assets for this?

@simonhong
Copy link
Member

@karenkliu I don't have new assets. Please attach here :)

@karenkliu
Copy link

@simonhong Just sent you a link to our GDrive where I exported the assets.

@rebron
Copy link
Collaborator

rebron commented Dec 7, 2020

Verified on:

Brave 1.18.69 Chromium: 87.0.4280.88 (Official Build) (x86_64 translated)
Revision 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS macOS Version 11.0.1 (Build 20B29)

Screen Shot 2020-12-07 at 3 07 52 PM
Screen Shot 2020-12-07 at 3 07 59 PM

@LaurenWags
Copy link
Member

thanks for checking this one @rebron 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team misc/icons OS/Desktop OS/macOS priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants