-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent conversion dates in logs #8689
Labels
bug
feature/ads
priority/P1
A very extremely bad problem. We might push a hotfix for it.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release/blocking
release-notes/exclude
Milestone
Comments
tmancey
added
the
priority/P1
A very extremely bad problem. We might push a hotfix for it.
label
Mar 13, 2020
32 tasks
This was referenced Mar 16, 2020
Verification passed on
Verified the min date for triggering the conversion is now respected and takes longer than 1 day
Verified trigger date in ad_conversions.json is the same as in logs Verified Verified passed with
Verification passed on
|
tmancey
pushed a commit
that referenced
this issue
Apr 9, 2020
Fixes inconsistent conversion dates in logs - 1.7.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
feature/ads
priority/P1
A very extremely bad problem. We might push a hotfix for it.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release/blocking
release-notes/exclude
There is a difference between when ad is suppose to convert and when it actually converts
Steps to Reproduce
Note: command line used:
/usr/bin/brave-browser --enable-logging=stderr --vmodule=brave_ads=3 --brave-ads-staging --rewards=staging=true
Actual result:
Ad conversion for
says it triggered on2020-03-14 13:38:42.000 UTC
, but it was actually triggered on2020-03-13 17:47:37 UTC
The conversion happens usually within 10 minutes after being triggered
Original logs:
Expected result:
Trigger date in log is the same as the actual trigger date
Reproduces how often:
100% repro rate
Brave version (brave://version info)
Verification passed on
cc @brave/legacy_qa @rebron @tmancey @jsecretan
The text was updated successfully, but these errors were encountered: