Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards NTP widget can be slow to show status immediately after enabling rewards #8698

Closed
simonhong opened this issue Mar 16, 2020 · 6 comments

Comments

@simonhong
Copy link
Member

Description

After enabling rewards with fresh profile, NTP shows proper rewards widget(Estimated earnings...).
Some seconds later, it back to display (Turn on Brave Rewards...).
After reloading NTP many times, I can see normal widgets again but reverted to default widget again.

Steps to Reproduce

  1. Start Nightly(1.8.11) with fresh profile
  2. Enable rewards and load new tab
  3. Check rewards widget shows properly

Actual result:

Rewards widget is back to default state(rewards off) in NTP after some seconds later

Expected result:

Rewards widget should not show default contents after rewards is enabled

Reproduces how often:

Easily

Brave version (brave://version info)

Version 1.8.11 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Not tested
  • Can you reproduce this issue with the beta channel? Not tested
  • Can you reproduce this issue with the dev channel? Not tested
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Failed to upload gif file due to size limitation.
See https://bravesoftware.slack.com/archives/C7VLGSR55/p1584320070272400

@bsclifton
Copy link
Member

Curious if this is related to brave/brave-core#4911

cc: @ryanml

@bsclifton
Copy link
Member

bsclifton commented Mar 16, 2020

comment removed - thought I had found issue, but was wrong about that

@bsclifton
Copy link
Member

Issue doesn't appear to be related to code after more investigation. It seems the new tab page widget is slow to update sometimes. If you wait there long enough, it will change state into the one that shows the balances. This can take a few seconds sometimes

@bsclifton bsclifton changed the title Rewards widget is back to default after enabling rewards Rewards NTP widget can be slow to show status immediately after enabling rewards Mar 16, 2020
@bsclifton
Copy link
Member

bsclifton commented Mar 16, 2020

@simonhong can you try this again? You may have gotten into a stuck state because of #8691

@bsclifton bsclifton added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Mar 16, 2020
@simonhong
Copy link
Member Author

@bsclifton My issue was not about slowness of widget state updating.
I had same issue with @karenkliu 's issue (#8711).
and that bug seems disappeared with latest nightly :)

@bsclifton
Copy link
Member

Perfect! I'll go ahead and close this then 😄

@bsclifton bsclifton removed the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Mar 17, 2020
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
@bbondy bbondy added the closed/duplicate Issue has already been reported label Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants