Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support $generichide adblock rules #8803

Closed
ryanbr opened this issue Mar 22, 2020 · 2 comments · Fixed by brave/brave-core#5581
Closed

Support $generichide adblock rules #8803

ryanbr opened this issue Mar 22, 2020 · 2 comments · Fixed by brave/brave-core#5581

Comments

@ryanbr
Copy link

ryanbr commented Mar 22, 2020

Description

We should support $generichide and $ghide (ubo style) in Brave, bring us inline with uBO, ABP, Adguard and other adblockers. Generichide filter is used to counter sites against Anti-adblock measures for checking generic css divs.

Popularity (as of 22/03/2020)

uBO Filters.txt (1535 generichide/ghide lines):
grep \$ghide filters.txt | wc -l
1535

Easylist (295 $generichide lines):
grep -r generichide * | wc -l
295

How its implemented:

Sample domain filter:
@@||domain.com^$generchide

Cosmetics wouldn't apply to domain.com:
##.adblock
###adbanner
###ad_text:not(textarea)
###tads + div + .c
Cosmetic would apply:
domain.com##.topBarAd
domain.com###sidebar-ad
domain.com##a[href^="https://dltags.com/"]

Original Implementation:
https://adblockplus.org/development-builds/new-filter-options-generichide-and-genericblock

Steps to Reproduce

  1. Visiting https://www.forbes.com
  2. Expecting uBo filters.txt @@||forbes.com^$generichide to hide the generic filters the site is using.
  3. See the work around: Hide generic elements on forbes.com adblock-lists#352
@ryanbr ryanbr added uBO-parity feature/shields/adblock Blocking ads & trackers with Shields labels Mar 22, 2020
@antonok-edm antonok-edm self-assigned this Jun 16, 2020
@antonok-edm antonok-edm added this to the 1.12.x - Nightly milestone Jun 17, 2020
@antonok-edm antonok-edm changed the title Supporting $generichide in Brave Support $generichide adblock rules Jun 23, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Jul 17, 2020

Verified passed with

Brave | 1.12.92 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-07-17 at 9 02 13 AM


Verification passed on


Brave | 1.12.94 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)



Verification passed on

Brave 1.12.99 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS
image image

@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 7, 2020
@srirambv
Copy link
Contributor

Removing OS/Android label as there is no aggressive/standard setting available yet on Android.

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment