Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos crash reports are missing channel #8864

Closed
bridiver opened this issue Mar 25, 2020 · 2 comments · Fixed by brave/brave-core#5064
Closed

macos crash reports are missing channel #8864

bridiver opened this issue Mar 25, 2020 · 2 comments · Fixed by brave/brave-core#5064

Comments

@bridiver
Copy link
Contributor

Description

Crash reports for beta, dev and nightly should have a channel

Steps to Reproduce

  1. using a non-release channel go to brave://crash
  2. go to brave://crashes and make sure that the crash has been sent
  3. check backtrace for the crash id metadata

Actual result:

No channel value exists

Expected result:

channel is correctly populated

Reproduces how often:

always

Brave version (brave://version info)

since brave/brave-core#2634

Version/Channel Information:

beta, dev and nightly

  • Can you reproduce this issue with the current release?
    no
  • Can you reproduce this issue with the beta channel?
    yes
  • Can you reproduce this issue with the dev channel?
    yes
  • Can you reproduce this issue with the nightly channel?
    yes
@kjozwiak
Copy link
Member

Moving issue into https://github.com/brave/brave-browser/milestone/92 👍

@LaurenWags
Copy link
Member

Verified passed using macOS Mojave 10.14.6 x64

Brave 1.7.85 Chromium: 80.0.3987.162 (Official Build) dev (64-bit)
Revision f2c5dd6138153bb0658091205bd1a1717f16081a-refs/branch-heads/3987@{#1034}
OS macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-04-03 at 11 52 05 AM

Checked and ensured that the crashes were reporting the correct channel:

Using brave://crash

Screen Shot 2020-04-03 at 11 52 28 AM

Using brave://crashgpu

Screen Shot 2020-04-03 at 11 53 04 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants