Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] NTP page image cropped after rotation #8892

Closed
btlechowski opened this issue Mar 27, 2020 · 1 comment · Fixed by brave/brave-core#5087
Closed

[Android] NTP page image cropped after rotation #8892

btlechowski opened this issue Mar 27, 2020 · 1 comment · Fixed by brave/brave-core#5087

Comments

@btlechowski
Copy link

After rotating the device, NTP image is cropped

Steps to reproduce

  1. Open NTP
  2. Open google.com in another tab
  3. Rotate the screen
  4. Make the NTP from step 1 active

Actual result

NTP image is cropped
Screenshot_20200327-180934_Brave

Expected result

NTP image is not cropped

Issue reproduces how often

100% repro rate

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Tablet
  • Android version: 9.0

Brave version

BraveModernarm v1.5.117 on Samsung Galaxy Tab S5e (Android 9.0)

cc @brave/legacy_qa @deeppandya @SergeyZhukovsky

@kjozwiak
Copy link
Member

kjozwiak commented May 9, 2020

Verification PASSED on Samsung Galaxy S10+ running Android 10 using the following build:

Brave 1.8.93 CR: 81.0.4044.129

Case #1

  • Open a NTP
  • Open another tab and load https://www.google.ca and rotate into landscape
  • switch back to the NTP (you'll notice it being cut off)

Case #2


Verification PASSED on Samsung Galaxy Tablet A running Android 9 using the following build:

Brave 1.8.93 CR: 81.0.4044.129

Case #1

  • Open a NTP
  • Open another tab and load https://www.google.ca and rotate into landscape
  • switch back to the NTP (you'll notice it being cut off)

Case #2


Verification passed on Samsung Galaxy J3 version 5.1.1 running BraveModernarm.apk 1.8.93

  • Verified STR from the description and from case 1 and case 2 mentioned above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants