Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads Purchase Intent funnel keyword with higher weight is ignored #8965

Closed
btlechowski opened this issue Apr 1, 2020 · 2 comments · Fixed by brave/brave-core#5180
Closed

Comments

@btlechowski
Copy link

Follow up to #8047

keyword dealer opening times has weight 3
keyword sell has weight 2

audi a5 dealer opening times - weight 3
audi a5 dealer opening times sell - weight 2
audi a5 sell dealer opening times - weight 2

The highest weight should be used

Steps to Reproduce

  1. Clean profile
  2. Connect to US
  3. Run Brave with command line: /usr/bin/brave-browser --enable-logging=stderr --vmodule=brave_ads=3 --brave-ads-staging --rewards=staging=true
  4. Enable Rewards
  5. Search for audi a5 dealer opening times sell in URL bar
  6. Check weight for automotive purchase intent by make-audi in Default/ads_service/client.json

Actual result:

audi a5 dealer opening times sell - weight 2

Expected result:

The highest weight should be used
audi a5 dealer opening times sell - weight 3

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @tmancey @moritzhaller

@LaurenWags
Copy link
Member

@moritzhaller when you get a chance, please ensure the following:

  • this issue is assigned a milestone (in most cases the milestone should probably be the version master is on)
  • corresponding PR is assigned a milestone (in most cases the milestone should probably be the version master is on)
  • corresponding PR has a test plan to test this issue

let me know if you have any questions 😄

@btlechowski
Copy link
Author

btlechowski commented May 5, 2020

Verification passed on

Brave 1.9.55 Chromium: 81.0.4044.129 (Official Build) dev (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#5180
Verified weight is 3.

"automotive purchase intent by make-audi":[{"timestamp_in_seconds":1588708652,"weight":3}]

Verification passed on

Brave | 1.9.63 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Verified test plan from brave/brave-core#5180
Verified weight is 3.

 "automotive purchase intent by make-audi": [
      {
        "timestamp_in_seconds": 1589276484,
        "weight": 3
      }
    ]

Verified passed with

Brave | 1.9.68 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)
    "automotive purchase intent by make-audi": [
      {
        "timestamp_in_seconds": 1589571879,
        "weight": 3
      }
    ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment