Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix url bar on tablet without rewards icon #8983

Closed
samartnik opened this issue Apr 2, 2020 · 1 comment · Fixed by brave/brave-core#5145
Closed

[Android] Fix url bar on tablet without rewards icon #8983

samartnik opened this issue Apr 2, 2020 · 1 comment · Fixed by brave/brave-core#5145
Assignees
@samartnik
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.7.x - Release

Comments

@samartnik
Copy link
Contributor

Description

On tablet without rewards icon url bar on the right side has straight corners. They should be rounded.
Screenshot from 2020-04-01 15-12-51

Steps to reproduce

  1. On tablet go to settings and hide rewards button
  2. Restart browser

Actual result

Straight corners on the right side

Expected result

Rounded corners on the right side

Issue reproduces how often

Easy

Issue happens on

  • Current Play Store version? yes
  • Beta build? yes

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.5.120

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information
@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label Apr 2, 2020
@samartnik samartnik added this to the 1.7.x - Beta milestone Apr 2, 2020
@samartnik samartnik self-assigned this Apr 2, 2020
@samartnik samartnik mentioned this issue Apr 2, 2020
Merged
32 tasks
@srirambv srirambv added the QA/Yes label Apr 3, 2020
This was referenced Apr 9, 2020
Closed
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Apr 23, 2020
Closed
2 tasks
@srirambv
Copy link
Contributor

Verification passed on Samsung Tab A with Android 9 running 1.7.100 x64 stable build

  • Verified disabling rewards retains rounded edge on URL bar
    image

@srirambv srirambv mentioned this issue May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.7.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed toolbar background for tablets brave/brave-core
3 participants
@kjozwiak @srirambv @samartnik