Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking All Device Recognition Attempts Breaks Map on coronavirus.iowa.gov #9139

Closed
ghost opened this issue Apr 10, 2020 · 5 comments
Closed
Labels
closed/invalid feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@ghost
Copy link

ghost commented Apr 10, 2020

Description

Blocking device fingerprinting on https://coronavirus.iowa.gov/ prevents the map from loading

Steps to Reproduce

  1. Go to https://coronavirus.iowa.gov/
  2. Click the Brave shields icon and set Brave to block all device recognition attempts
  3. Reload page and scroll down to the map

Actual result:

image

Expected result:

image

Reproduces how often:

Easily reproduced - Just make Brave block all device recognition attempts

Brave version (brave://version info)

Brave 1.5.123 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS Linux

(Also tested and doing the same thing on a Windows 10 laptop)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    Yes
  • Can you reproduce this issue with the beta channel?
    Yes
  • Can you reproduce this issue with the dev channel?
    Unknown
  • Can you reproduce this issue with the nightly channel?
    Unknown

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    Yes
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@bsclifton bsclifton added feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields webcompat/not-shields-related Sites are breaking because of something other than Shields. labels Apr 27, 2020
@bsclifton
Copy link
Member

cc: @pes10k

@pes10k
Copy link
Contributor

pes10k commented Apr 27, 2020

Yep, this is a result of APIs the embedded map uses that are also used for fingerprinting. So, currently there is not a way to allow the map to function and enable fingerprinting blocking.

However, #8787, which is currently being implemented, will enable us to allow sites to use more complex functionality in a way that still protects against fingerprinting.

@pes10k
Copy link
Contributor

pes10k commented Apr 30, 2020

@cybo1927 also, fwiw, the relevant bits of this change are in nightly currently. I'm able to browse that map with all fingerprinting protection blocked currently. If you're a nightly user, could you let us know if it looks fixed for you too?

@pes10k
Copy link
Contributor

pes10k commented Apr 30, 2020

Confirmed that this is fixed in nightly, and will be rolling out to other channels accordingly. Thanks again for the report @cybo1927 !

@pes10k pes10k closed this as completed Apr 30, 2020
@pes10k
Copy link
Contributor

pes10k commented Apr 30, 2020

Also, @cybo1927 , you're Brave version is pretty behind. You might just make sure you're on the current stable version of Brave (if not Beta or Nightly). Current stable is 1.8.x, and you're on 1.5.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/invalid feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Development

No branches or pull requests

3 participants