Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Safe Browsing" changes made in #8002 regressed with C81 #9266

Closed
LaurenWags opened this issue Apr 16, 2020 · 4 comments · Fixed by brave/brave-core#5335 or #9411
Closed

"Safe Browsing" changes made in #8002 regressed with C81 #9266

LaurenWags opened this issue Apr 16, 2020 · 4 comments · Fixed by brave/brave-core#5335 or #9411

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Apr 16, 2020

Description

Found while testing #9000

Issue #8002 made changes to Safe Browsing setting label for 1.7.x. When C81 was applied to 1.7.x, this issue regressed.

Setting was also moved farther down the list, but maybe this is expected, I'm unsure about that.

Steps to Reproduce

  1. Go to brave://settings/privacy
  2. Find Safe Browsing setting

Actual result:

Screen Shot 2020-04-16 at 11 41 20 AM

Expected result:

Screen Shot 2020-04-16 at 11 35 26 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.7.95 Chromium: 81.0.4044.92 (Official Build) (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa @rebron @bsclifton

@kjozwiak
Copy link
Member

Moving this out of the milestone. We'll get this fixed in 1.8.x as we need to release C81 ASAP.

@kjozwiak kjozwiak removed this from the 1.7.x - Release Hotfix 1 milestone Apr 20, 2020
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 20, 2020
@rebron
Copy link
Collaborator

rebron commented Apr 23, 2020

Current location of Google Safe Browsing setting is fine. Let's update the label though #8002
We'll be updating/reorganizing this whole Privacy and security section shortly.

@simonhong
Copy link
Member

Assigned to me. I can fix this quickly.

@kjozwiak
Copy link
Member

kjozwiak commented May 4, 2020

Verification PASSED on macOS 10.15.4 x64 Catalina using the following build:

Brave | 1.8.89 Chromium: 81.0.4044.129 (Official Build) (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | macOS Version 10.15.4 (Build 19E287)

Screen Shot 2020-05-04 at 1 00 31 AM

Verification passed on

Brave | 1.8.89 Chromium: 81.0.4044.129 (Official Build) (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

image

Verification passed on

Brave 1.8.89 Chromium: 81.0.4044.129 (Official Build) (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS Ubuntu 18.04 LTS

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment