-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ad Conversions on staging server fail due to 301 response code #9352
Comments
@btlechowski For ad conversions, the URL pattern must match the visited page and where that can be differences the patter must contain wildcards |
@tmancey on staging catalog conversion patterns will not work, because the page started to redirect. Were you able to convert ads on staging US catalog? |
@tmancey has updated catalog with new |
Verification passed on
The ad was converted using
Verified passed with
Note - encountered #9412 while testing. Verification passed on
The ad was converted using
|
On staging pretty much all ads with conversions are converted using
https://travala.com/booking?check_in=*
link. The server responds with 301 code and conversion is never triggeredIMPORTANT: This issue is reproducible on Brave 1.5.111 and conversions on staging were working on it #6536
Steps to Reproduce
https://travala.com/booking?check_in=*
https://travala.com/booking?check_in=*
Actual result:
Ad is not converted due to 301 response code from the server
The page is redirected to
https://www.travala.coom/booking?check_in=*
We don't handle redirects: #8663
Expected result:
Ads are converted on staging
Reproduces how often:
100% repro rate
Brave version (brave://version info)
cc @brave/legacy_qa @rebron @jsecretan @tmancey
The text was updated successfully, but these errors were encountered: