Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helps resolve https://github.com/brave/brave-browser/issues/8588 #8596

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

bsclifton
Copy link
Member

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton bsclifton added this to the 1.7.x - Nightly milestone Mar 9, 2020
@bsclifton bsclifton requested a review from ryanml March 9, 2020 18:46
@bsclifton bsclifton self-assigned this Mar 9, 2020
@bsclifton
Copy link
Member Author

rework of #8589

@bsclifton bsclifton merged commit 45a78d8 into master Mar 9, 2020
@bsclifton bsclifton deleted the bsc-fix-deps branch March 9, 2020 18:49
bsclifton added a commit that referenced this pull request Mar 11, 2020
Addresses #8588 on 1.5.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants