Make shortcut work on MacOS #2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
force-pushed
the
fix_shortcut_macos
branch
from
2191a95 to
0dfd0eb
Compare
Each channel uses different app/framework bundle name. Because of this, app_mode_loader can't find proper bundle. All combinations of app and framework bundle name are added for finding.
simonhong
force-pushed
the
fix_shortcut_macos
branch
from
0dfd0eb to
673bb95
Compare
|
Builder failed with below log. This is not directly related with this PR's change. |
brave-builds
pushed a commit
that referenced
this pull request
May 31, 2019
brave-builds
pushed a commit
that referenced
this pull request
May 31, 2019
This was referenced May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each channel uses different app/framework bundle name.
Because of this, app_mode_loader can't find proper bundle.
All combinations of app and framework bundle name pair should be added.
Fix brave/brave-browser#3750
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
yarn create_dist Release --channel=nightly --skip_signing./src/out/Release/unsigned_dmg/Brave Browser Nightly.dmgOr, test with debug build
yarn buildReviewer Checklist:
After-merge Checklist:
changes has landed on.