Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign libchallenge_bypass_ristretto.dylib on Mac. #2626

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jun 6, 2019

Fixes brave/brave-browser#4694

Patches chrome/installer/mac/signing/signing.py: adds
libchallenge_bypass_ristretto.dylib to the list of libs that are signed
during creation of dist.

Submitter Checklist:

Test Plan:

See steps to reproduce in brave/brave-browser#4694

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Fixes brave/brave-browser#4694

Patches chrome/installer/mac/signing/signing.py: adds
libchallenge_bypass_ristretto.dylib to the list of libs that are signed
during creation of dist.
@mkarolin mkarolin added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-ios Do not run CI builds for iOS labels Jun 6, 2019
@mkarolin mkarolin added this to the 0.68.x - Nightly milestone Jun 6, 2019
@mkarolin mkarolin self-assigned this Jun 6, 2019
@mkarolin mkarolin changed the title WIP: Sign libchallenge_bypass_ristretto.dylib on Mac. Sign libchallenge_bypass_ristretto.dylib on Mac. Jun 6, 2019
@mkarolin mkarolin merged commit ce50fe0 into master Jun 6, 2019
@mkarolin mkarolin deleted the maxk-fix-signing-of-libchallenge branch June 6, 2019 17:03
@mkarolin mkarolin removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Jun 6, 2019
mkarolin added a commit that referenced this pull request Jun 6, 2019
Sign libchallenge_bypass_ristretto.dylib on Mac.
mkarolin added a commit that referenced this pull request Jun 6, 2019
Sign libchallenge_bypass_ristretto.dylib on Mac.
mkarolin added a commit that referenced this pull request Jun 6, 2019
Sign libchallenge_bypass_ristretto.dylib on Mac.
Brandon-T added a commit that referenced this pull request Nov 19, 2024
[iOS] - Fix Leo yearly subscription ID on nightly (#2626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

creating shortcuts with "Open as window" selected launched empty windows
2 participants