Sign libchallenge_bypass_ristretto.dylib on Mac (Uplift to 0.67.x). #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign libchallenge_bypass_ristretto.dylib on Mac.
kjozwiak
approved these changes
Jun 7, 2019
There was a problem hiding this comment.
Uplift into 0.67.x approved after deliberating with @srirambv. Went through brave/brave-browser#4694 (comment) and verified that the issue has been resolved. Please ensure that all the correct labels are being used and that the appropriate issue is moved into the correct milestone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#4694
Uplift request from #2626
Should wait on validation of #2626 before uplifting.