Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign libchallenge_bypass_ristretto.dylib on Mac (Uplift to 0.65.x). #2629

Closed
wants to merge 1 commit into from
Closed

Sign libchallenge_bypass_ristretto.dylib on Mac (Uplift to 0.65.x). #2629

wants to merge 1 commit into from

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jun 6, 2019

Fixes brave/brave-browser#4694
Uplift request from #2626

Should wait on validation of #2626 before uplifting.

@mkarolin
Merge pull request #2626 from brave/maxk-fix-signing-of-libchallenge
474760c 
Sign libchallenge_bypass_ristretto.dylib on Mac.
@mkarolin mkarolin added the CI/skip Do not run CI builds (except noplatform) label Jun 6, 2019
@mkarolin mkarolin added this to the 0.65.x - Release milestone Jun 6, 2019
@mkarolin mkarolin requested a review from a team June 6, 2019 17:19
@mkarolin mkarolin self-assigned this Jun 6, 2019
kjozwiak
kjozwiak reviewed Jun 6, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.65.x denied as it's being released in about an hour. Both #2544 and #2558 were uplifted to 0.66.x so there' no need for this to go into 0.65.x

@kjozwiak kjozwiak removed this from the 0.65.x - Release milestone Jun 6, 2019
@kjozwiak kjozwiak closed this Jun 6, 2019
@kjozwiak kjozwiak deleted the maxk-fix-signing-of-libchallenge-0.65.x branch June 6, 2019 18:08
@kjozwiak kjozwiak removed the CI/skip Do not run CI builds (except noplatform) label Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak left review comments

Assignees

@mkarolin mkarolin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkarolin @kjozwiak