Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adblock-rust-ffi version #4540

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Conversation

antonok-edm
Copy link
Collaborator

@antonok-edm antonok-edm commented Feb 7, 2020

Fixes brave/brave-browser#8113

@petemill can you verify that this works on Windows?

Submitter Checklist:

Test Plan:

  1. Be on Windows 10
  2. Launch Brave; visit brave://flags/#brave-adblock-cosmetic-filtering
  3. enable the setting to enable cosmetic filtering
  4. Open a new tab and visit a website (ex: brave.com, github.com)
  5. Verify browser does not crash

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Contributor

@pes10k pes10k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmetic filtering crashes on Windows
4 participants