Changed help link for connection info #5095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samartnik
added
CI/skip-linux
CI/skip-macos-x64
bridiver
reviewed
Mar 30, 2020
| @CalledByNative | ||
| private void addMoreInfoLink(String linkText) { | ||
| mMoreInfoLink = new TextView(mContext); | ||
| - mLinkUrl = HELP_URL; |
There was a problem hiding this comment.
we should be able to handle this with brave_static_redirect_network_delegate_helper.cc
samartnik
force-pushed
the
android_changed_help_link
branch
from
2500097 to
0ad5b9e
Compare
bridiver
reviewed
Mar 30, 2020
| public boolean onNewIntent(Intent intent) { | ||
| // Redirect requests if necessary | ||
| String url = getUrlFromIntent(intent); | ||
| if (url != null && url.equals(CONNECTION_INFO_HELP_URL)) { |
There was a problem hiding this comment.
we'll probably want to break this stuff out into helper classes eventually, but lgtm for now
bridiver
approved these changes
Mar 30, 2020
This was referenced Mar 30, 2020
samartnik
added a commit
that referenced
this pull request
Mar 31, 2020
samartnik
added a commit
that referenced
this pull request
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#8899
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.