Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable prefetch-privacy-changes flag by default #5731

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Jun 3, 2020

Resolves brave/brave-browser#8319

Submitter Checklist:

Test Plan:

Open https://fmarier.github.io/brave-testing/prefetch.html and follow the instructions.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier requested review from jumde and simonhong June 3, 2020 22:02
@fmarier fmarier self-assigned this Jun 3, 2020
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.
Can you add this feature to BraveMainDelegateBrowserTest.EnabledFeatures test case?

@fmarier fmarier force-pushed the francois-enable-prefetch-privacy-changes-8319 branch from 79bacba to 77c337d Compare June 4, 2020 01:07
@fmarier
Copy link
Member Author

fmarier commented Jun 4, 2020

Can you add this feature to BraveMainDelegateBrowserTest.EnabledFeatures test case?

Thanks @simonhong, I wasn't aware of that test.

@fmarier fmarier added this to the 1.12.x - Nightly milestone Jun 4, 2020
@fmarier
Copy link
Member Author

fmarier commented Jun 4, 2020

@fmarier fmarier merged commit 7a1f099 into master Jun 4, 2020
@fmarier fmarier deleted the francois-enable-prefetch-privacy-changes-8319 branch June 4, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable the prefetch-privacy-changes flag by default
2 participants