-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Confirmations into ads process #6248
Conversation
@fmarier Could you please review |
5ade9cb
to
41d8ee9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brave_license_helper.py
changes look good.
099a129
to
e7356e2
Compare
21a65af
to
852cf79
Compare
abcabac
to
e1bb1e6
Compare
9c87c93
to
bb70216
Compare
5ce7233
to
a3c3276
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and reviewed purchase intent, ad conversions and subdivision targeting. Reviewed search providers. LGTM!
.../src/bat/ads/internal/classification/purchase_intent_classifier/purchase_intent_classifier.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving rewards code, but @tmancey before you merge it please remove base::ScopedAllowBlockingForTesting allow_blocking;
for every test as we need to find another way to do it, we can't add it to every test (it was not a problem before, not sure why it's now as you removed all confirmations from rewards code). Also make sure that CI is passing before merging
CI failed on windows (agent was removed), everything else is green https://ci.brave.com/job/pr-brave-browser-issues-9870/33/flowGraphTable/. Restarting windows |
Resolves brave/brave-browser#9870
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.