-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable security components #7521
Conversation
@mherrmann if your fix(#7164) is merged, maybe this PR is not needed? |
Do I understand correctly that the goal of this PR is to get If this delay is acceptable, then I think it would be cleaner to merge #7164 first, then simplify this present PR. |
Yes, it seems this PR want to enable these two components. and avoiding install during the startup would be nice. |
Let's do that. I'll wait for that PR to merge and then rebase this one. |
3912528
to
8aaea4f
Compare
Thanks @simonhong . I have updated the patch with all that's needed now. |
4424731
to
9facc4d
Compare
9facc4d
to
20f1e92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
20f1e92
to
db31b77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Resolves brave/brave-browser#12999 and brave/brave-browser#13010
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed).Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on.
Test Plan:
chrome://components
.