From c9f71f41e1e92b760c7e1e4641104433dfc1042d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Buczek?= Date: Mon, 18 Sep 2023 19:48:44 +0200 Subject: [PATCH] Fix #8056: Update P3A callout text. (#8083) --- .../BrowserViewController+Callout.swift | 2 +- Sources/BraveStrings/BraveStrings.swift | 5 +++++ Sources/Onboarding/Welcome/WelcomeViewController.swift | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Callout.swift b/Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Callout.swift index dd466f55d91..ce622bb1950 100644 --- a/Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Callout.swift +++ b/Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Callout.swift @@ -75,7 +75,7 @@ extension BrowserViewController { toggleTitle: Strings.Callout.p3aCalloutToggleTitle, details: Strings.Callout.p3aCalloutDescription, linkDescription: Strings.Callout.p3aCalloutLinkTitle, - primaryButtonTitle: Strings.done, + primaryButtonTitle: Strings.P3A.continueButton, toggleAction: { [weak self] isOn in self?.braveCore.p3aUtils.isP3AEnabled = isOn }, diff --git a/Sources/BraveStrings/BraveStrings.swift b/Sources/BraveStrings/BraveStrings.swift index 6e877213678..7235ec09c9b 100644 --- a/Sources/BraveStrings/BraveStrings.swift +++ b/Sources/BraveStrings/BraveStrings.swift @@ -4576,6 +4576,11 @@ extension Strings { "p3a.settingSubtitle", tableName: "BraveShared", bundle: .module, value: "Anonymised P3A info helps Brave estimate overall usage and ensure we're improving popular features.", comment: "A subtitle shown on the setting that toggles analytics on Brave.") + + public static let continueButton = NSLocalizedString( + "p3a.continue", tableName: "BraveShared", bundle: .module, + value: "Continue", + comment: "A button to proceed with the rest of the user onboarding after they see the P3A introduction. It means to continue browsing or continue with the rest of the onboarding") } } diff --git a/Sources/Onboarding/Welcome/WelcomeViewController.swift b/Sources/Onboarding/Welcome/WelcomeViewController.swift index d0bd5121360..bfab1d61fbf 100644 --- a/Sources/Onboarding/Welcome/WelcomeViewController.swift +++ b/Sources/Onboarding/Welcome/WelcomeViewController.swift @@ -364,7 +364,7 @@ public class WelcomeViewController: UIViewController { toggleTitle: Strings.Callout.p3aCalloutToggleTitle, details: Strings.Callout.p3aCalloutDescription, linkDescription: Strings.Callout.p3aCalloutLinkTitle, - primaryButtonTitle: Strings.done, + primaryButtonTitle: Strings.P3A.continueButton, toggleAction: { [weak self] isOn in self?.p3aUtilities.isP3AEnabled = isOn },