From 2c4b7202fcc07b49e8d087f1d82780e4d225bec9 Mon Sep 17 00:00:00 2001 From: Joe Gallo Date: Tue, 17 Jan 2017 23:45:35 -0500 Subject: [PATCH] allow search icon to show while loading (#6532) Allow the search icon to show while loading. This removes a display lag time for URL bar icons. Fixes #6518. --- app/renderer/components/urlBarIcon.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/renderer/components/urlBarIcon.js b/app/renderer/components/urlBarIcon.js index bf6194b99f9..1f570e44a64 100644 --- a/app/renderer/components/urlBarIcon.js +++ b/app/renderer/components/urlBarIcon.js @@ -35,18 +35,15 @@ class UrlBarIcon extends ImmutableComponent { } /** * search icon: - * - does not show when loading * - does not show when in title mode * - shows when urlbar is active (ex: you can type) * - is a catch-all for: about pages, files, etc */ get isSearch () { - const showSearch = this.props.active && - this.props.loading === false + const showSearch = this.props.active const defaultToSearch = (!this.isSecure && !this.isInsecure && !showSearch) && !this.props.titleMode && - this.props.loading === false && !this.isAboutPage return showSearch || defaultToSearch