Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Link for Release Notes leads to 404 #10370

Closed
jonathansampson opened this issue Aug 9, 2017 · 6 comments
Closed

Link for Release Notes leads to 404 #10370

jonathansampson opened this issue Aug 9, 2017 · 6 comments
Labels
bug duplicate Issue has already been reported feature/about-pages

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Aug 9, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Clicking the Release Notes link in about:brave leads to a GitHub 404.

Reported on Twitter.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Desktop

  • Brave Version (revision SHA):
    0.18.20 (tweet), 0.19.1

  • Steps to reproduce:

    1. Navigate to about:brave
    2. Click Release Notes link
  • Actual result:
    A 404 is presented

  • Expected result:
    Release notes are presented

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

@jonathansampson jonathansampson added this to the 0.20.x (Developer Channel) milestone Aug 9, 2017
@cndouglas
Copy link

0.19.x is still in beta, so there's no release notes yet.

@jonathansampson
Copy link
Collaborator Author

@liunkae This happened for a user on 18.20 as well. See this tweet. If we have a link there, it should lead someplace other than a 404.

@cndouglas
Copy link

0.18.20 is still in beta too. 😉 0.18.14 is the current release.

@luixxiul
Copy link
Contributor

luixxiul commented Aug 9, 2017

It works for me on 0.18.20.

Maybe the link was not correctly applied when the user opened about:brave. I remember I experienced the similar issue, and for me the link was not defined, ie https://github.com/brave/browser-laptop/releases/tag/undefined IIRC. I'm not sure how to reproduce the issue.

@clairelo
Copy link

Versions etc are in my tweet thread, but I didn't open about. It was from your most recent dev version and it was the message that popped up after I updated (not from about). It's been happening for a few versions now for me. Try signing out of GitHub to reproduce.

@alexwykoff alexwykoff modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 15, 2017
@ghost ghost assigned bsclifton Aug 22, 2017
@bsclifton bsclifton modified the milestones: 0.19.x (Beta Channel), 0.21.x (Nightly Channel) Aug 22, 2017
@bsclifton
Copy link
Member

Closing this as a dupe of #10515. I believe the problem is that Beta builds have never worked properly on Windows. Because they were marked as dev instead of beta, they would be linking to a non-existent version of the issue

@bsclifton bsclifton added the duplicate Issue has already been reported label Aug 22, 2017
@bsclifton bsclifton removed their assignment Aug 22, 2017
@bsclifton bsclifton removed this from the 0.19.x (Beta Channel) milestone Aug 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug duplicate Issue has already been reported feature/about-pages
Projects
None yet
Development

No branches or pull requests

6 participants