Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Verified publisher icon not shown on manual upgrade #10814

Closed
srirambv opened this issue Sep 6, 2017 · 5 comments
Closed

Verified publisher icon not shown on manual upgrade #10814

srirambv opened this issue Sep 6, 2017 · 5 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Sep 6, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Verified publisher icon not shown on manual upgrade

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):

Brave 0.18.27
rev eba55a1
Muon 4.3.16
  • Steps to reproduce:

    1. Install 0.18.23 build, do not enable payments
    2. Manually upgrade to 0.18.27 by running the setup
    3. Once updated to 0.18.27, enable payments and visit any verified publisher link (eg: brianbondy.com)
    4. Wait for the entry to be added in the ledger table, no verified publisher icon is shown in URL or in ledger table
    5. Quit and restart browser, no change
    6. Disable/enable payments, no change
    7. Delete all ledger*.json files from brave profile and relaunch browser and visit the same sites, verified publisher icon is shown
  • Actual result:
    Verified publisher icon not shown on manual upgrade

  • Expected result:
    Should show the verified publisher icon irrespective of when payment is enabled and how the browser update is done

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes,
    Updated manually from 0.17.13 to 0.18.14, no verified publisher icon shown
    Auto updated from 0.18.14 to 0.18.23, still no verified publisher icon shown

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
    cc: @mrose17 @NejcZdovc @cezaraugusto

@luixxiul
Copy link
Contributor

@srirambv does this issue still exist?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Sep 23, 2017
@ghost ghost added the priority/P4 Minor loss of function. Workaround usually present. label Sep 26, 2017
@ghost ghost added this to the 0.19.x (Beta Channel) milestone Sep 26, 2017
@ghost
Copy link

ghost commented Sep 26, 2017

May be resolved by refactor #11037 . QA to recheck after

@luixxiul luixxiul removed the needs-info Another team member needs information from the PR/issue opener. label Sep 26, 2017
@srirambv
Copy link
Collaborator Author

srirambv commented Sep 27, 2017

Yes this is still an issue on the latest build.

Edit: The verified publisher icon shows up after a delay of ~10 secs on 0.19.20. Yet to verify on the older builds

@NejcZdovc
Copy link
Contributor

verified publisher icon is delayed, so it's ok if only appears after 10 sec

@NejcZdovc
Copy link
Contributor

closing for now as it works

@NejcZdovc NejcZdovc self-assigned this Sep 29, 2017
@luixxiul luixxiul removed this from the 0.19.x (Beta Channel) milestone Sep 29, 2017
@luixxiul luixxiul added wontfix invalid and removed bug priority/P4 Minor loss of function. Workaround usually present. wontfix labels Sep 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants