Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Icon for mixed content is unintentionally shown as green #13163

Closed
bsclifton opened this issue Feb 16, 2018 · 4 comments
Closed

Icon for mixed content is unintentionally shown as green #13163

bsclifton opened this issue Feb 16, 2018 · 4 comments
Assignees
@MargarytaChepiga @srirambv
Labels
regression release/blocking release-notes/exclude

Comments

@bsclifton
Copy link
Member

bsclifton commented Feb 16, 2018 •
edited
Loading

Test plan

See #13164

Description

Unintentionally caused by #13147

Steps to Reproduce

  1. Visit https://www.wsj.com/europe

Actual result:

image

Expected result:
Page should be mixed (HTTP/HTTPS); the unlock icon should be gray
screen shot 2018-02-15 at 11 02 26 pm

Reproduces how often:

Brave Version

master
about:brave info:

Reproducible on current live release:

Additional Information
@bsclifton bsclifton added this to the 0.23.x (Nightly Channel) milestone Feb 16, 2018
@bsclifton bsclifton self-assigned this Feb 16, 2018
@bsclifton
Copy link
Member Author

@MargarytaChepiga I self-assigned this issue to reserve it for you 😄 Will keep an eye out for a PR. Please let me know if you have any questions

@srirambv srirambv mentioned this issue Feb 16, 2018
Merged
10 tasks
@MargarytaChepiga
Copy link
Contributor

@bsclifton Thank you!

@bsclifton
Copy link
Member Author

bsclifton commented Feb 16, 2018 •
edited
Loading

@MargarytaChepiga you probably already saw, but @srirambv had an assist for you to check out and review 😄 #13164

@bsclifton bsclifton modified the milestones: 0.23.x (Nightly Channel), 0.24.x Feb 26, 2018
@bsclifton
Copy link
Member Author

Closing as this was fixed with 49a9b73

The proper fix is now contained in #13164 😄

@bsclifton bsclifton removed this from the Completed work milestone Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MargarytaChepiga MargarytaChepiga

@srirambv srirambv

Labels
regression release/blocking release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bsclifton @MargarytaChepiga @srirambv