Add a confirmation dialog for "Close Other Tabs" contextual menu action.

[bradleyrichter]

This action is not undoable and can be triggered accidentally.

[bbondy]

Users can undo closed tabs, I think a dialog would be a tad annoying here. One other data point is that there is no confirmation in Chrome.

[bradleyrichter]

It would be useful if you had more then 20 that would be closed all at once. And a data point - we are better than chrome. : )

But anyway, low priority since you can reopen them one at a time.

[bbondy]

Yep agreed low priority and as long as it gives an option to not show anymore, all good with me. Thanks.

[luixxiul]

I'm trying like this:

  items.push({
    label: locale.translation('closeOtherTabs'),
    click: (item, focusedWindow) => {
      if (focusedWindow) {
        if (confirm(locale.translation('confirmcloseOtherTabs'))) {
          focusedWindow.webContents.send(messages.SHORTCUT_CLOSE_OTHER_FRAMES, tabKey, true, true)
        }
      }
    }

This surely works on Ubuntu, displaying a pop-up, but I'm getting this one to commit:

  /home/test/browser-laptop/js/contextMenus.js:412:13: 'confirm' is not defined.

Do I have to define 'confirm'? If so would you please tell me how to?

[bbondy]

I think you are looking for this:
https://github.com/electron/electron/blob/master/docs/api/dialog.md#dialogshowmessageboxbrowserwindow-options-callback

[bsclifton]

Closing in favor of brave/brave-browser#912