Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Avoid using display:table with pixels on about:preferences #2096

Closed
luixxiul opened this issue Jun 6, 2016 · 1 comment
Closed

Avoid using display:table with pixels on about:preferences #2096

luixxiul opened this issue Jun 6, 2016 · 1 comment
Labels
design A design change, especially one which needs input from the design team. l10n

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jun 6, 2016

Describe the issue you encountered: From a viewpoint of l10n, it is not a good idea to combine display: table with width: px because it does not solve a bug on about:preferences like this:

It was fixed with #2042 once, but just as a workaround, not in principle.

Expected behavior: I think the better solution is to use display: flex with percent. Great part of about:preferences would need rewriting in this case.

  • Brave Version: Master Branch
@luixxiul luixxiul added design A design change, especially one which needs input from the design team. l10n labels Jun 6, 2016
@luixxiul luixxiul changed the title Avoid using display:table with pixels Avoid using display:table with pixels on about:preferences Jun 6, 2016
@luixxiul
Copy link
Contributor Author

I think this has been solved in 0.11.1 about:preferences. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. l10n
Projects
None yet
Development

No branches or pull requests

1 participant