Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Interface needs facelift on history shown when long press on nav back/forward #2737

Closed
bsclifton opened this issue Jul 27, 2016 · 1 comment
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. design A design change, especially one which needs input from the design team. polish Nice to have — usually related to front-end/visual tasks. wontfix

Comments

@bsclifton
Copy link
Member

bsclifton commented Jul 27, 2016

Initial implementation of history showing when you long press on the navigator back/forward buttons was done w/ #2699. Some additional polish done w/ #2733

In the original issue, @bradleyrichter proposed the following look and feel for the history menu:

alt text

Feature descriptions (text copied verbatim from original comment):

  • hover help balloon to remind you that mouse down has hidden functionality
  • holding down the back button should open a tab-specific list of pages ordered based on the history of page visits only for that tab
  • holding down the forward button (when available) should open a list of the available forward pages in the tabs history
  • each entry uses the same styling as the search results popup which includes both the page title and the URL
  • This popup list window can be opened via long press with selection on mouse up, or as a right-click with selection on mouse down
  • at the bottom, there are 2 choices.
    • All the way back (skips back to the top of the history chain)
    • show all history... (link to open about:history when it becomes available)

additional note:

  • the list should only show 10 entries at a time. Selecting the last one in the list will of course refresh the list when it is next used after that page loads. Then another 10 will be shown.
@bsclifton bsclifton added design A design change, especially one which needs input from the design team. polish Nice to have — usually related to front-end/visual tasks. labels Jul 27, 2016
@luixxiul luixxiul added this to the 1.1.0 milestone Jan 10, 2017
@alexwykoff alexwykoff modified the milestones: 1.1.0, Backlog Nov 1, 2017
@bsclifton bsclifton added addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. wontfix labels Sep 1, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 1, 2018
@bsclifton
Copy link
Member Author

This isn't entirely addressed with brave-core (ex: url not shown), but it's pretty close:
screen shot 2018-09-01 at 12 16 44 am

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. design A design change, especially one which needs input from the design team. polish Nice to have — usually related to front-end/visual tasks. wontfix
Projects
None yet
Development

No branches or pull requests

3 participants