Alt Gtr(Right Alt Key) doesn't show File Menu on Windows 7.

[srirambv]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Pressing Alt-Gtr key on Windows 7 doesn't show the file menu.
Keyboard settings: EN-US, EN-UK, EN-IN, EN-IR

Expected behavior:
Pressing Alt key (right/left) show show the file menu when hide menu bar is enabled in pref

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 7 x32/64 Professional
• Brave Version:
  0.11.2 Dev Beta 2
• Steps to reproduce:
  1.
  2.
  3.
• Screenshot if needed:
• Any related issues:

[bsclifton]

This appears to be the root cause:
https://github.com/brave/electron/blob/master/atom/browser/native_window_views.cc#L83

If we want the right ALT button sent also, which has a different virtual key code, we'd need to update the code like so:

bool IsAltKey(const content::NativeWebKeyboardEvent& event) {
  return event.windowsKeyCode == ui::VKEY_MENU || event.windowsKeyCode == VKEY_ALTGR;
}

Searching the electron code, this doesn't seem like it would have a large impact. It would also enable keyboard accelerators to work with the right alt (that is something else you can test, @srirambv). I'm curious how other browsers handle this too?

Good find 😄

[bsclifton]

Closing this as we don't want this behavior. For more info, see #4626