Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Clear Browsing History better #3065

Closed
srirambv opened this issue Aug 9, 2016 · 3 comments
Closed

Clear Browsing History better #3065

srirambv opened this issue Aug 9, 2016 · 3 comments
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/history wontfix

Comments

@srirambv
Copy link
Collaborator

srirambv commented Aug 9, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Clear Browsing Data now doesn't delete browsing history. Page history still visible when back/forward button is long pressed.

Expected behavior:
Should clear browsing history as expected.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.11.4 Dev RC1
  • Steps to reproduce:
    1.
    2.
    3.
  • Screenshot if needed:
    ezgif-2505718510
  • Any related issues:
@bbondy
Copy link
Member

bbondy commented Aug 10, 2016

ya this, nor the clear cache option we had before doesn't clear back-forward cache on webviews, only the history that we store. This is valid but not new.

@bbondy bbondy changed the title Clear Browsing Data now doesn't delete browsing history Clear Browsing History better Aug 10, 2016
@bbondy
Copy link
Member

bbondy commented Aug 10, 2016

the browser history is still available in the history property on the frame. after i clear browser history, my session-store-1-dev file has entries like:

"frames":[{"canGoBack":false,"canGoForward":false,"computedThemeColor":"rgb(51, 51, 51)","endLoadTime":1470784542553,"findDetail":{"caseSensitivity":false,"searchString":""},"fingerprintingProtection":{},"history":["http://samy.pl/evercookie/","https://www.google.com/#q=abcdyahoo","https://www.google.com/#q=abcdyahoo","https://www.bing.com/"], ...

Also for closedFrames.

@bbondy bbondy added this to the 0.11.5dev milestone Aug 10, 2016
@bbondy bbondy mentioned this issue Aug 10, 2016
3 tasks
@bbondy bbondy modified the milestones: 0.11.6dev, 0.11.5dev Aug 12, 2016
@bbondy bbondy modified the milestones: 1.0.0, 0.11.6dev Aug 23, 2016
@brave brave deleted a comment from NumDeP Sep 30, 2017
@alexwykoff alexwykoff modified the milestones: 1.0.0, Backlog Nov 1, 2017
@kjozwiak
Copy link
Member

kjozwiak commented Apr 4, 2018

This might be out of scope, but closing all currently opened tabs/windows when "Clearing All" could be super useful. I've been bitten a few times where I cleared the history, the browser was restarted and I accidentally hovered over a discarded tab which was then placed back onto about:history.

@bsclifton bsclifton added wontfix addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. labels Oct 1, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Oct 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/history wontfix
Projects
None yet
Development

No branches or pull requests

7 participants