Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Restoring from a state with 0 windows on macOS should remember position of last window #3247

Closed
bbondy opened this issue Aug 18, 2016 · 3 comments · Fixed by #5102
Closed

Comments

@bbondy
Copy link
Member

bbondy commented Aug 18, 2016

We do have code for remembering window placement for new windows but it doesn't seem to be used with the following steps:

  • Launch Brave.
  • Open one window. Move it to the left side of the screen.
  • Close the one window.
  • Quit Brave.

Actual results:
Launch Brave. A new blank window should open in the center of the screen.

Expected results:
It should be on the left side, where you last window was.

@bbondy
Copy link
Member Author

bbondy commented Aug 18, 2016

cc @bsclifton

@bsclifton
Copy link
Member

bsclifton commented Aug 18, 2016

@bbondy - This makes sense; the position is part of the WindowState, which gets discarded when closed. When it's time to quit, an event is fired and Brave will save the WindowState for any open BrowserWindows (which there are none anymore).

Doesn't happen on Windows/Linux because closing the last window will close the app

We could save this as part of the AppState?

@bbondy
Copy link
Member Author

bbondy commented Aug 19, 2016

We already store defaultWindowWidth and defaultWindowHeight in app storage, so it should just be updating that I think.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants