Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ledger settings box alignment and style corrections #3523

Closed
bradleyrichter opened this issue Aug 29, 2016 · 5 comments
Closed

Ledger settings box alignment and style corrections #3523

bradleyrichter opened this issue Aug 29, 2016 · 5 comments
Assignees
Labels
design A design change, especially one which needs input from the design team. feature/rewards polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-Win32 QA/checked-Win64
Milestone

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Aug 29, 2016

Here is a list of small layout and style issues needed to polish the nav/settings area of the main ledger screen.

(note: be sure not to break existing pref panel elements while adjusting these styles in the ledger screen)

  1. fix all elements to align-left as window is enlarged
  2. reduce monthly contribution menu width
  3. add dollar symbol, decimal, cents to contribution and account balance
  4. correct switch label colors
    • use additional text string in grey, for “off”

    • create new switch label style for “on” label to be orange
    • set "notifications" switch to the normal switch label style
  5. correct font sizes and weights
  6. align elements
    • button height = menu height
  7. group elements into DIVs to accommodate button text for l10n.
    (button width should push next column to the right)

image

@bradleyrichter bradleyrichter added design A design change, especially one which needs input from the design team. polish Nice to have — usually related to front-end/visual tasks. feature/rewards labels Aug 29, 2016
@bradleyrichter bradleyrichter added this to the 0.11.6dev milestone Aug 29, 2016
@mrose17
Copy link
Member

mrose17 commented Aug 29, 2016

while we are looking at alignment issues, can we go back to use right justification on rank/ views/ time spent and percentage?
pasted image at 2016_08_29 08_54 am

@bradleyrichter
Copy link
Contributor Author

@mrose17 I'll make a new issue for the ledger list/table

@jkup
Copy link
Contributor

jkup commented Aug 29, 2016

Issue number 3 has been moved into a separate ticket: #3533

@luixxiul
Copy link
Contributor

font-weight for elements in thead is set to 400 due to #paymentsContainer .walletBar th. Is it intended?

clipboard01

@jkup
Copy link
Contributor

jkup commented Aug 31, 2016

@luixxiul it is and it isn't. Ideally @bradleyrichter wants those to be a weight in between our current normal and bold but (my understanding) is that Arial only supports those two sizes on most peoples systems. I think the plan is to eventually bundle a font with the app so that we can have more control?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/rewards polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-Win32 QA/checked-Win64
Projects
None yet
Development

No branches or pull requests

5 participants