Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Windows 7 - selection problems with first item in custom menu #4142

Closed
bsclifton opened this issue Sep 21, 2016 · 3 comments
Closed

Windows 7 - selection problems with first item in custom menu #4142

bsclifton opened this issue Sep 21, 2016 · 3 comments

Comments

@bsclifton
Copy link
Member

bsclifton commented Sep 21, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When opening the menu and using the mouse, the first item doesn't show as selected and isn't clickable until you move almost halfway down the HTML element (see attached screenshot for a demo).

Expected behavior:
Menu should be selectable as soon as cursor enters the context menu element

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 7 Pro x64
  • Brave Version:
    HEAD on master
  • Steps to reproduce:
    1. Launch Brave
    2. Press ALT to show the menu
    3. Put mouse over File
    4. Move mouse slightly down into the context menu item
    5. Notice it's not selected
  • Screenshot if needed:
    win7-menu
  • Any related issues: Titlebar on Windows has a lot of wasted space #3036
@bsclifton bsclifton added this to the 0.12.2dev milestone Sep 21, 2016
@bsclifton bsclifton added the help wanted The PR/issue opener needs help to complete/report the task. label Sep 21, 2016
@bsclifton
Copy link
Member Author

bsclifton commented Sep 21, 2016

This is a tough one... Here is what I know about the issue (thanks to @bbondy to helping me troubleshoot):

  • When the menu item is not selected, you can click and drag. I added the style -webkit-app-region: no-drag; to the element, but there is no change.
  • If you edit the CSS or use the DOM inspector to find "contextMenuSingle" and give it a border-top of 0 pixels, the issue is fixed. But why? This is not an ideal solution
  • In the render method for js/controls/main.js, there is a variable shouldAllowWindowDrag. I tried manually setting this to false... but there is no change.

@luixxiul
Copy link
Contributor

Moving to 0.12.3?

@bsclifton
Copy link
Member Author

No- will be working on solving it this morning. Stay tuned...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants