Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Long bookmark folder names should be truncated #4739

Closed
alexwykoff opened this issue Oct 13, 2016 · 1 comment
Closed

Long bookmark folder names should be truncated #4739

alexwykoff opened this issue Oct 13, 2016 · 1 comment
Assignees
Labels
design A design change, especially one which needs input from the design team. feature/bookmarks QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
I realize that @srirambv's comment in #4690 is contrary to my opinion, but the downside of having folder names which are not truncated is that the bookmark names become oddly truncated then eventually are stacked below the folders.

Expected behavior:
It would seem that proportional columns make the most sense in this case if we must maintain columns. @bradleyrichter it may be worth revisiting this interaction and allow for a different method of selecting folders and shuffling bookmarks between them.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on Windows 7 and OS X.
  • Brave Version:
    0.12.5 Preview 2
  • Steps to reproduce:
    1. Create a bookmark folder with an obnoxiously long name.
    2. Import a lot of bookmarks.
  • Screenshot if needed:
    screen shot 2016-10-13 at 7 33 54 pm
    screen shot 2016-10-13 at 6 58 30 pm
  • Any related issues:
@alexwykoff alexwykoff added design A design change, especially one which needs input from the design team. feature/bookmarks labels Oct 13, 2016
@alexwykoff alexwykoff added this to the 0.12.6dev milestone Oct 13, 2016
@bradleyrichter
Copy link
Contributor

Unless this will happen by accident, it's an edge case. So let's set a max width to 50% and no scrolling.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/bookmarks QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Development

No branches or pull requests

6 participants