Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tests being ran for Travis CI are broken #5082

Closed
bsclifton opened this issue Oct 24, 2016 · 8 comments
Closed

Tests being ran for Travis CI are broken #5082

bsclifton opened this issue Oct 24, 2016 · 8 comments
Labels

Comments

@bsclifton
Copy link
Member

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
You can view any build in travis-ci.org and you'll notice that only 1 test is ran, which is a find bar test. I reproduced this on my local machine (macOS)

Our contributor @Sh1d0w had dug in and reporting findings about when this started here:
#5046 (comment)

Expected behavior:
All tests should be ran

  • Platform (Win7, 8, 10? macOS? Linux distro?):
  • Brave Version:
  • Steps to reproduce:
    1.
    2.
    3.
  • Screenshot if needed:
  • Any related issues:
@Sh1d0w
Copy link

Sh1d0w commented Oct 24, 2016

@bsclifton I also noticed that. It all started here

@Sh1d0w Sh1d0w added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Oct 24, 2016
@bsclifton
Copy link
Member Author

bsclifton commented Oct 24, 2016

The first commit that fails is this:
08213f2

@bsclifton
Copy link
Member Author

bsclifton commented Oct 24, 2016

Possible clue
The ones which work were checking out dev-channel:
git clone --depth=50 --branch=dev-channel https://github.com/brave/browser-laptop.git brave/browser-laptop

while the ones failing are checking out master

@bsclifton
Copy link
Member Author

I think this might have something to do with it:
e12fca0#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

From the console:

    ERROR in aboutPages.entry.js from UglifyJs
    SyntaxError: Unexpected token: name (length) [./~/punycode/punycode.js:55,0]

@bsclifton
Copy link
Member Author

Things I've tried (which did not work... even though it works locally on my mac w/ node v6.3)

@bsclifton
Copy link
Member Author

bsclifton commented Oct 25, 2016

I believe the tests not running is fixed with 79c38f5 cc: @bbondy

Perhaps the above error is not related? Although, I do think it's the cause of the problem @srirambv has (where about pages are not working)

@diracdeltas
Copy link
Member

Looks like this can be closed now that tests are all running again. https://travis-ci.org/brave/browser-laptop/builds

re: the punycode module, i added it because NPM docs say that the core module is now deprecated, but it's not strictly needed for any reason yet.

@bsclifton
Copy link
Member Author

@diracdeltas yup- I did see that, and it looks like you did it properly... I'm curious why the webpack uglify plugin is complaining ☹️

@luixxiul luixxiul removed the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Oct 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants