Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

about:newtabs - pinning is not working #5337

Closed
bsclifton opened this issue Nov 2, 2016 · 2 comments · Fixed by #5645
Closed

about:newtabs - pinning is not working #5337

bsclifton opened this issue Nov 2, 2016 · 2 comments · Fixed by #5645
Assignees
@cezaraugusto
Labels
feature/newtab QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.10 release

Comments

@bsclifton
Copy link
Member

I believe this has the same root cause as #5321

Clicking the pin does not work currently. For some items, it would look like it's pinned, but you can't unpin
@bsclifton bsclifton added this to the 0.12.9dev milestone Nov 2, 2016
This was referenced Nov 4, 2016
Merged
Closed
This was referenced Nov 10, 2016
Closed
Closed
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Nov 14, 2016
Closed
@cezaraugusto cezaraugusto mentioned this issue Nov 14, 2016
Merged
4 tasks
@cezaraugusto
Copy link
Contributor

Reopening after #5583

@cezaraugusto cezaraugusto reopened this Nov 14, 2016
@bsclifton bsclifton mentioned this issue Nov 15, 2016
Closed
@bbondy
Copy link
Member

bbondy commented Nov 15, 2016

Moving to 0.12.10

@bbondy bbondy modified the milestones: 0.12.10 release , 0.12.9dev Nov 15, 2016
@cezaraugusto cezaraugusto mentioned this issue Nov 15, 2016
Merged
3 tasks
This was referenced Nov 21, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
feature/newtab QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.10 release
Development

Successfully merging a pull request may close this issue.

fix pinning topSites not respecting position
6 participants
@bbondy @alexwykoff @luixxiul @cezaraugusto @bsclifton @srirambv