Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

the buttons on about:preferences#payments need more paddings #6081

Closed
luixxiul opened this issue Dec 8, 2016 · 4 comments · Fixed by #6047
Closed

the buttons on about:preferences#payments need more paddings #6081

luixxiul opened this issue Dec 8, 2016 · 4 comments · Fixed by #6047
Assignees
@luixxiul
Labels
feature/rewards misc/button polish Nice to have — usually related to front-end/visual tasks. QA/no-qa-needed release-notes/exclude
Milestone
0.13.0

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 8, 2016

Describe the issue you encountered:

screenshot 2016-12-08 12 41 23

Expected behavior:

screenshot 2016-12-08 12 44 06
@luixxiul luixxiul added design A design change, especially one which needs input from the design team. feature/rewards misc/button labels Dec 8, 2016
@luixxiul luixxiul added this to the 0.13.1 milestone Dec 8, 2016
@luixxiul luixxiul self-assigned this Dec 8, 2016
@luixxiul luixxiul modified the milestones: 0.13.0, 0.13.1 Dec 9, 2016
@luixxiul
Copy link
Contributor Author

luixxiul commented Dec 9, 2016

This has been fixed with #5916: https://github.com/brave/browser-laptop/pull/5916/files#diff-fca7d0eef4fe1430dbdc3733b1fc5fdaR164

@luixxiul luixxiul closed this as completed Dec 9, 2016
@luixxiul luixxiul reopened this Dec 9, 2016
@luixxiul
Copy link
Contributor Author

luixxiul commented Dec 9, 2016

The property is not applied for now because #paymentsContainer was replaced .paymentsContainer.

@luixxiul
Copy link
Contributor Author

@bsclifton please reset the milestone of this if you are too busy to do a review for #6047 ;-)

@luixxiul luixxiul mentioned this issue Dec 15, 2016
Merged
4 tasks
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul luixxiul mentioned this issue Jan 16, 2017
Closed
@luixxiul luixxiul added QA/no-qa-needed release-notes/exclude polish Nice to have — usually related to front-end/visual tasks. and removed QA/checked-Win32 QA/test-plan-specified design A design change, especially one which needs input from the design team. labels Jan 17, 2017
@luixxiul
Copy link
Contributor Author

Added QA/no qa needed as the issue has been superseded with #6216

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/rewards misc/button polish Nice to have — usually related to front-end/visual tasks. QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Refactor about:preferences#payments followups
2 participants
@bbondy @luixxiul