Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed URL address bar adding deleted text back immediately #6956

Closed
echosa opened this issue Jan 31, 2017 · 2 comments · Fixed by #7534
Closed

Fixed URL address bar adding deleted text back immediately #6956

echosa opened this issue Jan 31, 2017 · 2 comments · Fixed by #7534

Comments

@echosa
Copy link
Contributor

echosa commented Jan 31, 2017

Test plan

#7534 (comment)


  • Did you search for similar issues before submitting this one?

Yes

  • Describe the issue you encountered:

If I'm on a page with a URL like this:

https://www.amazon.com/BraceUP-Adjustable-Wrist-Support-Black/dp/B00ZMZPGMK/ref=sr_1_3_a_it?ie=UTF8&qid=1485897673&sr=8-3&keywords=wrist%2Bsupports&th=1

and I want to get rid of all the params so that the URL is just this:

https://www.amazon.com/BraceUP-Adjustable-Wrist-Support-Black/dp/B00ZMZPGMK

When I click in the address bar and delete the params, the URL immediately auto-completes and adds them back. This results in me clicking in the address bar, deleting the params, and immediately pressing enter, but ending up on the same page because the autocomplete filled the URL parameters back end before I was able to press return.

What I have to do is click in the URL bar, delete the parameters, delete the parameters again after the autocomplete kicks in (provided I remember to wait and do so), then press return. It's quite annoying, really.

I'll put a gif of it in the screenshots area below.

  • Platform (Win7, 8, 10? macOS? Linux distro?):

OS X 10.11.6

  • Brave Version (revision SHA):

0.13.0 (8ca0127)

The text I deleted comes back.

  • Expected result:

The text I deleted should not be there anymore.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

Yes.

  • Is this an issue in the currently released version?

Yes.

  • Can this issue be consistently reproduced?

Yes.

  • Screenshot if needed:

screen recording 2017-01-31 at 03 25 pm

@cndouglas
Copy link

I think this would be fixed by #6537 (URL autocomplete should offer the option of only completing the hostname).

@cndouglas
Copy link

It looks like this has been fixed by PR #7534 and will be included in 0.14.0.

@luixxiul luixxiul added this to the 0.14.0 milestone Mar 16, 2017
@alexwykoff alexwykoff mentioned this issue Mar 17, 2017
44 tasks
@alexwykoff alexwykoff changed the title URL address bar adds deleted text back immediately, have to delete twice Fixed URL address bar adding deleted text back immediately Mar 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.