Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Wallet creation fail on RC build #7948

Closed
srirambv opened this issue Mar 29, 2017 · 4 comments
Closed

Wallet creation fail on RC build #7948

srirambv opened this issue Mar 29, 2017 · 4 comments

Comments

@srirambv
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Wallet creation fail on RC build

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.14.0
    rev e6fba42

  • Steps to reproduce:

    1. Do a clean install of 0.14.0 RC1
    2. Enable payments, nothing happens, wallet is not created
    3. Click on the create wallet button, nothing happens, console doesn't record logs
  • Actual result:
    Wallet creation fails

  • Expected result:
    Should create wallet after enabling payments

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    ledger

  • Any related issues:
    cc: @mrose17

@NejcZdovc
Copy link
Contributor

It's working on the latest master fd6763e

@luixxiul
Copy link
Contributor

I experience the issue on the latest RC, on Windows 10.

@bbondy
Copy link
Member

bbondy commented Mar 29, 2017

Seems to also be because of the packaging excluding node_modules subdirs of node_modules.
We'll have to come back to this one at a later date, I'll file it as an issue but reverted it here.
c2c0149

@luixxiul
Copy link
Contributor

luixxiul commented Mar 29, 2017

the files which c2c0149 reverted had been reverted multiple times. The first commit was to fix #7896.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants