Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Spellchecking not working with Swedish as system language on Windows #7967

Closed
Jacalz opened this issue Mar 29, 2017 · 13 comments
Closed

Spellchecking not working with Swedish as system language on Windows #7967

Jacalz opened this issue Mar 29, 2017 · 13 comments

Comments

@Jacalz
Copy link
Contributor

Jacalz commented Mar 29, 2017

Spell checking is not working for me on any version of Brave on Windows 10 Pro x64 and it doesent matter if I remove my whole session under %appdata% it just doesent work, but it works on MacOS Sierra. This is annoying because checking if spell checking is working is part of my Manual tests. 😞

Original Description

  • Did you search for similar issues before submitting this one?
    Yes
  • Describe the issue you encountered:
    Spell check is not working in 0.14.0 RC2
  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 Pro x64
  • Brave Version (revision SHA):
    0.14.0 RC2
  • Steps to reproduce:
    Open a github issue and type some misspellings, make sure they are underlined. (Copyed from manual tests template)
  • Actual result:
    No indication of miss spelling
  • Expected result:
    Spell check sould uderline that you have spelled that word wrong
  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    YES
  • Is this an issue in the currently released version?
    Not really
  • Can this issue be consistently reproduced?
    Yes, I tested in gmail also to see if it was a site specific thing but it isnt 👎
@luixxiul
Copy link
Contributor

Are you testing by setting the language to English?

@Jacalz
Copy link
Contributor Author

Jacalz commented Mar 29, 2017

I have Brave set to English and I was writing in English... @luixxiul

@alexwykoff
Copy link
Contributor

I could not reproduce that on OS X with 0.14.0 RC2
@srirambv could you give it a try?

@srirambv
Copy link
Collaborator

Works for me
7967

@Jacalz
Copy link
Contributor Author

Jacalz commented Mar 30, 2017

Still doesent work for me even on a new profile 👎 @srirambv

@luixxiul
Copy link
Contributor

It does work on github, while it does not on the search form on mail.google.com. I am not sure this has been worked so far.

@bsclifton
Copy link
Member

@Jacalz can you try on a different site? maybe just any site which has a textbox, type into it (like @luixxiul suggests, maybe GitHub... for example, this page)

@Jacalz
Copy link
Contributor Author

Jacalz commented Apr 10, 2017

Still not working on 0.14.1, works on my Mac but not on my windows pc...

@Jacalz Jacalz changed the title Spell check not working in 0.14.0 RC2 Spell check not working Apr 10, 2017
@Jacalz
Copy link
Contributor Author

Jacalz commented Apr 10, 2017

image
Can there be a problem when having windows set to Swedish because this comfirmation dialog says "Github Säger" and that is the equivilant of "Github Says". It says it regordles of what language brave is set to so I might be on to something 👍 @luixxiul @bsclifton @alexwykoff @srirambv

@Jacalz
Copy link
Contributor Author

Jacalz commented Apr 10, 2017

Wtf, Found the solution 👍
I changed Windows language to English and then Back to Swedish and now it works 😕
Closing this since the issue is resolved but you can keep writing here if you have some useful info to say 😄

@Jacalz Jacalz closed this as completed Apr 10, 2017
@Jacalz
Copy link
Contributor Author

Jacalz commented Apr 13, 2017

The issue is back again after these 3 days, seems like brave has a problem with Windows set to Swedish 😕

@Jacalz Jacalz reopened this Apr 13, 2017
@luixxiul luixxiul added the bug label Jun 4, 2017
@Jacalz Jacalz changed the title Spell check not working Spell check not working with Swedish as system language Jul 7, 2017
@Jacalz Jacalz added this to the 0.18.x (Beta Channel) milestone Jul 23, 2017
@Jacalz
Copy link
Contributor Author

Jacalz commented Jul 23, 2017

Fixed by #9951

@Jacalz
Copy link
Contributor Author

Jacalz commented Jul 23, 2017

Assigned to 0.18.x milestone because it got fixed in 0.18.x 👍 Really happy 🙂

@Jacalz Jacalz changed the title Spell check not working with Swedish as system language Spellchecking not working with Swedish as system language on Windows Jul 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants