LastPass won't stop asking for 2FA code

[stshank]

• Did you search for similar issues before submitting this one?
  yes

• Describe the issue you encountered:
  LastPass periodically requires me to reauthenticate with its second factor (in my case, a 6-digit code from Google Authenticator). Sometimes in Brave a new tab opens with a LastPass dialog box up asking me to authenticate again, but no amount of entering new codes makes the dialog. However, the LastPass icon turns from gray to red (or maybe it was red all along?), indicating the authentication was successful or unnecessary. The problem is sporadic. I'm not sure if it comes more frequently than the 30-day period that an authentication should last.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  MacOS 10.12.6 beta (but this issue has been around for a few months for me)

• Brave Version (revision SHA):
  Brave 0.15.314
  rev 75ffa36
  Muon 3.0.202
  libchromiumcontent 58.0.3029.110
  V8 5.8.283.38
  Node.js 7.9.0
  Update Channel dev
  os.platform darwin
  os.release 16.7.0
  os.arch x64

• Steps to reproduce:

  1. Install LastPass with dual-factor authentication
  2. Wait

• Actual result:
  LastPass 2FA authentication dialog box doesn't go away

• Expected result:
  LastPass 2FA authentication works (or isn't triggered when it's not needed)

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  unclear

• Is this an issue in the currently released version?
  yes

• Can this issue be consistently reproduced?
  unclear but it's happened to me several times.

• Screenshot if needed:

[bsclifton]

cc: @jonathansampson

[jonathansampson]

I've setup Google Authenticator on my end, and will proceed to use it with LastPass. Thank you for the heads-up; we'll see to it that any issues are given appropriate consideration, and are resolved a.s.a.p.!

Upon setting up 2FA with Google Authenticator, I signed out of LastPass in Brave. Upon signing back in, a new tab was opened, and I was asked for my time-based code. When I provided it, LastPass' icon turned red, focus was shifted back to my previous tab, but the Authenticator tab remained present.

I suspect the tabs persistence is a known issue, but you should still be authenticated.

Confirmed, the issue here is with:

function close_tab(e) {
    get_all_windows({ populate: !0 }, function(t) {
        var a = !1;
        if (1 == t.length && 1 == get_tabs_length(t[0]) && gettabid(get_tabs(t[0])[0]) == gettabid(e) && (openURL(g_isopera ? "about:blank" : "about:newtab"), a = !0), g_ischrome)
            try {
                chrome.tabs.remove(gettabid(e))
            } catch (e) {
                console_error(e)
            }
        else
            (g_issafari || g_isopera || g_ismaxthon || g_isfirefoxsdk) && (a ? setTimeout(function() {
                e.close()
            }, 0) : e.close())
    })
}

The chrome.tabs.remove(gettabid(e)) line doesn't remove the Google Authenticator tab.

Tracking this with #4687

[luixxiul]

As #4687 was fixed for 0.18, let's confirm this issue was also fixed.