From 8ba6679428fd2c4c7d204c378808a847b83542d0 Mon Sep 17 00:00:00 2001 From: Suguru Hirahara Date: Sat, 12 Nov 2016 23:57:08 +0900 Subject: [PATCH] Small changes of the icons on about pages On about:bookmarks - Aligned fa-file-o favicon on about:bookmarks On about:preferences#security - Restyled widevineInfo (line-height, paddings around the icons, cursor:pointer on them) Closes #6137 Auditors: @bbondy @bradleyrichter Test Plan: 1. Bookmark about:newtab 2. Open about:bookmarks 3. Make sure the favicon of the bookmarked new tab has 16px width 4. Open about:preferences#security 5. Make sure the icons below "Plugin Settings" are indented 6. Check the line-height of the subtexts in Google Widevine Support 7. Check the cursor on the two info icons --- app/renderer/components/widevineInfo.js | 21 ++++----------------- js/about/preferences.js | 6 +++--- less/about/bookmarks.less | 5 +++++ less/about/preferences.less | 17 +++++++++++------ 4 files changed, 23 insertions(+), 26 deletions(-) diff --git a/app/renderer/components/widevineInfo.js b/app/renderer/components/widevineInfo.js index 6f2727a7dc2..ca7960afce6 100644 --- a/app/renderer/components/widevineInfo.js +++ b/app/renderer/components/widevineInfo.js @@ -12,17 +12,6 @@ const React = require('react') const ImmutableComponent = require('../../../js/components/immutableComponent') const appConfig = require('../../../js/constants/appConfig') -const widevineInfoStyle = { - paddingBottom: 10 -} -const widevineInfoIconStyle = { - padding: 5 -} - -const subtextStyle = { - marginBottom: 7 -} - class WidevineInfo extends ImmutableComponent { constructor () { super() @@ -40,19 +29,17 @@ class WidevineInfo extends ImmutableComponent { }, true) } render () { - return
-
+ return
+
-
- diff --git a/js/about/preferences.js b/js/about/preferences.js index 8785ea31fe4..44143843eb5 100644 --- a/js/about/preferences.js +++ b/js/about/preferences.js @@ -1606,19 +1606,19 @@ class SecurityTab extends ImmutableComponent { { isDarwin || isWindows ?
- +   {'Adobe'}.
:
- +
}
- +