From 030e44f2fcd8be9fea78240fd18e3e8b6732202b Mon Sep 17 00:00:00 2001 From: "Alex N. Jose" Date: Wed, 23 Aug 2023 19:20:42 +0000 Subject: [PATCH] [LCPP] Make LCPP web_tests exclusive to VirtualTests Based on the feedback on crrev.com/c/4767918, this CL switches LCPP web_tests to be exclusively virtual and drops the TestExpectations. Bug: 1419756 Change-Id: Ib5acfd90b68d136ee526edfa8d419988b7d5e405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4792062 Reviewed-by: Weizhong Xia Reviewed-by: Kouhei Ueno Commit-Queue: Kouhei Ueno Cr-Commit-Position: refs/heads/main@{#1187421} --- third_party/blink/web_tests/TestExpectations | 3 --- third_party/blink/web_tests/VirtualTestSuites | 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/third_party/blink/web_tests/TestExpectations b/third_party/blink/web_tests/TestExpectations index b134104dc5da9f..eeab309e3d3ac7 100644 --- a/third_party/blink/web_tests/TestExpectations +++ b/third_party/blink/web_tests/TestExpectations @@ -6656,9 +6656,6 @@ crbug.com/626703 virtual/css-highlight-overlay-painting/external/wpt/css/css-hig # Gardening 2023-07-06 crbug.com/1462500 [ Win ] media/picture-in-picture/picture-in-picture-interstitial-sizing.html [ Failure Pass ] -# Until LCPP is unflagged, LCPP tests run in virtual tests. -crbug.com/1419756 http/tests/lcp_critical_path_predictor/* [ Crash Failure ] - # Accessibility causes unrelated rendering change crbug.com/1470474 fast/ruby/ruby-position-modern-japanese-fonts.html [ Failure Pass ] diff --git a/third_party/blink/web_tests/VirtualTestSuites b/third_party/blink/web_tests/VirtualTestSuites index 6c4e8c31d93310..682f1e3afe2b6c 100644 --- a/third_party/blink/web_tests/VirtualTestSuites +++ b/third_party/blink/web_tests/VirtualTestSuites @@ -2423,6 +2423,7 @@ "bases": [ "http/tests/lcp_critical_path_predictor" ], + "exclusive_tests": "ALL", "args": [ "--enable-features=LCPCriticalPathPredictor", "--disable-threaded-compositing", "--disable-threaded-animation"