From 8a1d31ccc457f92028135176b7f650630d09bee9 Mon Sep 17 00:00:00 2001 From: Daniel Stinson-Diess Date: Fri, 22 Mar 2024 19:16:08 -0500 Subject: [PATCH] fix(enrich_kv_store_set): default to 0 duration (#151) Documentation states that this is an optional parameter, but the initializing function will return an error if it's not set. > transform: enrich_kv_store_set: time: invalid duration "" --- build/config/substation.libsonnet | 2 +- transform/enrich_kv_store_set.go | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/build/config/substation.libsonnet b/build/config/substation.libsonnet index e2136435..d140ee55 100644 --- a/build/config/substation.libsonnet +++ b/build/config/substation.libsonnet @@ -412,7 +412,7 @@ settings: std.prune(std.mergePatch(default, $.helpers.abbv(settings))), }, set(settings={}): { - local default = $.transform.enrich.kv_store.default { ttl_key: null, ttl_offset: null }, + local default = $.transform.enrich.kv_store.default { ttl_key: null, ttl_offset: "0s" }, type: 'enrich_kv_store_set', settings: std.prune(std.mergePatch(default, $.helpers.abbv(settings))), diff --git a/transform/enrich_kv_store_set.go b/transform/enrich_kv_store_set.go index 396fc13b..7510fef3 100644 --- a/transform/enrich_kv_store_set.go +++ b/transform/enrich_kv_store_set.go @@ -89,6 +89,10 @@ func newEnrichKVStoreSet(_ context.Context, cfg config.Config) (*enrichKVStoreSe return nil, fmt.Errorf("transform: enrich_kv_store_set: %v", err) } + if conf.TTLOffset == "" { + conf.TTLOffset = "0s" + } + dur, err := time.ParseDuration(conf.TTLOffset) if err != nil { return nil, fmt.Errorf("transform: enrich_kv_store_set: %v", err)